remoting: Remove legacy video pipeline components [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Apr 21, 2026, 1:37:50 AM (3 days ago) Apr 21
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 1:38:45 AM (3 days ago) Apr 21
to Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Yuwei Huang voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 1:49:39 AM (3 days ago) Apr 21
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 21, 2026, 9:52:56 AM (3 days ago) Apr 21
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Code-Review | +1 |
1 comment
File remoting/test/it2me_standalone_host.cc
File-level comment, Patchset 6 (Latest):
Joe Downing . unresolved
I would be fine removing this. I've been on the fence about keeping this around for a while now as I wasn't sure if it would be useful or not. I think we've entered an era where it is trivial to whip something up on demand if we need a utility like this so I'm fine if it is removed since it is easily replaced.
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 2:21:58 PM (3 days ago) Apr 21
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Auto-Submit | +1 |
1 comment
File remoting/test/it2me_standalone_host.cc
Joe Downing . resolved
I would be fine removing this. I've been on the fence about keeping this around for a while now as I wasn't sure if it would be useful or not. I think we've entered an era where it is trivial to whip something up on demand if we need a utility like this so I'm fine if it is removed since it is easily replaced.
Yuwei Huang
Yeah. We also have [it2me_cli_host](https://source.chromium.org/chromium/chromium/src/+/main:remoting/test/it2me_cli_host_main.cc), which should supposedly start a real IT2ME host and print the access code, but last time I tried it, it was not working. Maybe it needs to be run inside a graphical session or something. Not sure..
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 3:00:17 PM (3 days ago) Apr 21
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang submitted the change![]( "Open in Gerrit")
Change information
Commit message:
remoting: Remove legacy video pipeline components
Identify and remove dead code from legacy Chromotocol video components
that are no longer used in the WebRTC-based architecture. This includes
VideoEncoder, VideoDecoder, and supporting classes like VideoFramePump
and CaptureScheduler.
Also remove the redundant video_encode_task_runner infrastructure and
the "ChromotingEncodeThread" from ChromotingHost and
ChromotingHostContext.
Also some changes to keep it2me_standalone_host building, but I doubt
that it still works. TBH no one really uses it, and it could probably
be removed.
Bug: 375470501
Change-Id: I7ca697289508305e434f6cfa87b80d37923ebc5c
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Auto-Submit: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618356}
Files:
- M build/check_gn_headers_allowlist.txt
- M remoting/BUILD.gn
- M remoting/codec/BUILD.gn
- M remoting/codec/GEMINI.md
- D remoting/codec/codec_test.cc
- D remoting/codec/codec_test.h
- D remoting/codec/video_decoder.h
- D remoting/codec/video_decoder_verbatim.cc
- D remoting/codec/video_decoder_verbatim.h
- D remoting/codec/video_decoder_vpx.cc
- D remoting/codec/video_decoder_vpx.h
- D remoting/codec/video_decoder_vpx_unittest.cc
- D remoting/codec/video_encoder.cc
- D remoting/codec/video_encoder.h
- D remoting/codec/video_encoder_helper.cc
- D remoting/codec/video_encoder_helper.h
- D remoting/codec/video_encoder_helper_unittest.cc
- D remoting/codec/video_encoder_verbatim.cc
- D remoting/codec/video_encoder_verbatim.h
- D remoting/codec/video_encoder_verbatim_unittest.cc
- D remoting/codec/video_encoder_vpx.cc
- D remoting/codec/video_encoder_vpx.h
- D remoting/codec/video_encoder_vpx_unittest.cc
- M remoting/host/chromoting_host.cc
- M remoting/host/chromoting_host.h
- M remoting/host/chromoting_host_context.cc
- M remoting/host/chromoting_host_context.h
- M remoting/host/chromoting_host_context_unittest.cc
- M remoting/host/chromoting_host_unittest.cc
- M remoting/host/client_session.cc
- M remoting/host/host_mock_objects.cc
- M remoting/host/it2me/it2me_host.cc
- M remoting/host/remoting_me2me_host.cc
- M remoting/protocol/BUILD.gn
- D remoting/protocol/capture_scheduler.cc
- D remoting/protocol/capture_scheduler.h
- D remoting/protocol/capture_scheduler_unittest.cc
- M remoting/protocol/fake_connection_to_client.cc
- M remoting/protocol/fake_connection_to_client.h
- D remoting/protocol/video_feedback_stub.h
- D remoting/protocol/video_frame_pump.cc
- D remoting/protocol/video_frame_pump.h
- D remoting/protocol/video_frame_pump_unittest.cc
- M remoting/protocol/webrtc_connection_to_client.cc
- M remoting/test/BUILD.gn
- M remoting/test/fake_connection_event_logger.cc
- M remoting/test/fake_connection_event_logger.h
- M remoting/test/it2me_standalone_host.cc
Change size: XL
Delta: 48 files changed, 17 insertions(+), 3412 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages