[M145] Fix the cronjob script in the remoting Debian package. [chromium/src : refs/branch-heads/7632]
0 views
Skip to first unread message
Chrome Cherry Picker (Gerrit)
Jan 14, 2026, 11:15:52 PM (6 days ago) Jan 14
to Lambros Lambrou, AyeAye, chromotin...@chromium.org
Chrome Cherry Picker voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Jan 14, 2026, 11:16:17 PM (6 days ago) Jan 14
to Lambros Lambrou, Chrome Cherry Picker, AyeAye, chromotin...@chromium.org
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 14, 2026, 11:34:47 PM (6 days ago) Jan 14
to Lambros Lambrou, Chrome Cherry Picker, Rubber Stamper, AyeAye, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M145] Fix the cronjob script in the remoting Debian package.
Original change's description:
> Fix the cronjob script in the remoting Debian package.
>
> The remoting Debian package includes a cronjob script, which is used
> to install an APT repository source and add a Google signing-key to APT.
>
> This file is generated using the same templates that Chrome uses for
> its Debian packaging. A recent refactoring changed Chrome's
> template-processor to use a Python library, but it left the remoting
> builder using the old Bash-based implementation.
>
> This CL fixes remoting's processor to work with Chrome's updated
> templates. Care is taken to correctly handle the substitutions
> `@@repoconfigregex` and `@@repoconfig`, because one is a substring
> of the other. This wasn't a problem with the previous template language
> because it used the `@@foo@@` syntax.
>
> This is a short-term fix intended for merging onto M145 branch. In
> the longer term, remoting should use the same template-processor as
> Chrome.
>
> Bug: 475586372
> Change-Id: Icf5717461fa65d3ee587be78540b87f000cbc81e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7465286
> Auto-Submit: Lambros Lambrou <lambros...@chromium.org>
> Commit-Queue: Yuwei Huang <yuw...@chromium.org>
> Reviewed-by: Yuwei Huang <yuw...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1568869}
(cherry picked from commit d0679de4a20f3c762f7f92bc481154f84253d27a)
Bug: 475964883,475586372
Change-Id: Icf5717461fa65d3ee587be78540b87f000cbc81e
Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7632@{#100}
Cr-Branched-From: 0bbdf2913883391365383b0a5dfe7bf9fd1a5213-refs/heads/main@{#1568190}
Files:
- M remoting/host/installer/linux/build-deb.sh
- M remoting/host/installer/linux/debian/repo.cron
- M remoting/host/installer/linux/installer.include
Change size: S
Delta: 3 files changed, 15 insertions(+), 6 deletions(-)
Branch: refs/branch-heads/7632
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages