[MiraclePtr] Rewrite templated container fields to raw_ptr [chromium/src : main]
José Arturo Barrera (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Arthur Sonzogni
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Arthur Sonzogni added 3 comments![]( "Open in Gerrit")
Message
**[Early Review]** This is an automated early review generated by an LLM. It is intended to help you catch obvious issues early and **potentially save a round of code review**.
If you find any suggestion irrelevant, please feel free to *ignore* or *close* it.
_I am going to do a manual code review when I wake up._
Please see suggestions below.
3 comments
const std::vector<raw_ptr<TabSlotView>>& dragging_views,**[Early Review]**
Avoid using `raw_ptr` in function parameters, including within containers like `std::vector`. Keep the parameter as `const std::vector<TabSlotView*>&` (or prefer `base::span<TabSlotView* const>`). The conversion to `raw_ptr` should occur when storing the pointers in class members, similar to the approach used in `declarative_rule.h` in this patch.
const std::vector<raw_ptr<TabSlotView>>& dragging_views,**[Early Review]**
Avoid using `raw_ptr` in function parameters, including within containers. Keep the parameter as `const std::vector<TabSlotView*>&` (or prefer `base::span<TabSlotView* const>`).
std::vector<raw_ptr<TabSlotView>> dragging_views;**[Early Review]**
Do not use `raw_ptr` for local variables on the stack, including within containers. Local variables are already safe from UAFs due to their stack lifetime, and `raw_ptr` introduces unnecessary overhead. Keep this as `std::vector<TabSlotView*>`.
Related details
- Arthur Sonzogni
- José Arturo Barrera
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |