Temporarily disable FTL iq_stanza protobuf parsing/sending [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Apr 21, 2026, 5:37:48 PM (2 days ago) Apr 21
to chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 21, 2026, 7:02:05 PM (2 days ago) Apr 21
to Yuwei Huang, April Zhou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Joe Downing . resolved
PTAL!
My plan is to merge this CL into M148 after it lands as it affects an important Chrome OS EDU use case, then I'll re-enable it and land the fixes. Please note that website-initiated connections are not affected as they do not provide a protobuf stanza (yet).
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 7:09:21 PM (2 days ago) Apr 21
to Joe Downing, April Zhou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 21, 2026, 7:09:43 PM (2 days ago) Apr 21
to Yuwei Huang, April Zhou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 7:40:47 PM (2 days ago) Apr 21
to Joe Downing, Yuwei Huang, April Zhou, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Temporarily disable FTL iq_stanza protobuf parsing/sending
This is a temporary workaround for a crash where the Jingle
session-initiate message lacked the required <description>
payload when parsed from an FTL protobuf message. Disabling
iq_stanza parsing and sending forces the system to fall back
to the older serialized XML payload, which correctly includes
all required fields.
Bug: 504910955
Change-Id: I97046b597902678dedf246b756ee39eb5f948eb9
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618546}
Files:
- M remoting/signaling/ftl_signal_strategy.cc
- M remoting/signaling/ftl_signal_strategy_unittest.cc
Change size: M
Delta: 2 files changed, 15 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages