[remoting]: Reject XML stanzas with DTDs in SignalStrategy. [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Mar 31, 2026, 3:53:23 PM (3 days ago) Mar 31
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 31, 2026, 4:18:46 PM (3 days ago) Mar 31
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 31, 2026, 4:22:07 PM (3 days ago) Mar 31
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 31, 2026, 4:25:00 PM (3 days ago) Mar 31
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[remoting]: Reject XML stanzas with DTDs in SignalStrategy.
This change adds a pre-parsing check to SignalStrategy::ParseStanzaXml
to reject XML payloads containing <!DOCTYPE to prevent the underlying
unhardened Expat XML parser from processing untrusted DTDs.
Bug: 497828214
Change-Id: I224b1048c3d1b1f504e96c3f40a301e782f85665
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608066}
Files:
- M remoting/signaling/ftl_signal_strategy_unittest.cc
- M remoting/signaling/signal_strategy.cc
Change size: S
Delta: 2 files changed, 23 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages