Remove stray remoting/host/security_key/security_key_message_writer.cc [chromium/src : main]

0 views
Skip to first unread message

Andrew Paseltiner (Gerrit)

unread,
Mar 10, 2026, 11:04:32 AM (4 days ago) Mar 10
to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Andrew Paseltiner voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4633ac1d4d2cb6fce0fe2739125a4a6e134e4c2
Gerrit-Change-Number: 7653139
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 15:04:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
Mar 10, 2026, 12:02:50 PM (4 days ago) Mar 10
to Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Andrew Paseltiner

Joe Downing voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4633ac1d4d2cb6fce0fe2739125a4a6e134e4c2
Gerrit-Change-Number: 7653139
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 16:02:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 10, 2026, 12:05:26 PM (4 days ago) Mar 10
to Andrew Paseltiner, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove stray remoting/host/security_key/security_key_message_writer.cc

This file is not part of any BUILD target. Code archaeology shows that
it wasn't included in the list of sources in
https://codereview.chromium.org/2164753004/patch/20001/30103 either, so
it hasn't been built in years. Regardless, its contents do not match the
corresponding header file, which defines a pure virtual interface.
Bug: 593736
Change-Id: Id4633ac1d4d2cb6fce0fe2739125a4a6e134e4c2
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Joe Downing <joe...@chromium.org>
Auto-Submit: Andrew Paseltiner <apase...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1597106}
Files:
  • D remoting/host/security_key/security_key_message_writer.cc
Change size: M
Delta: 1 file changed, 0 insertions(+), 81 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joe Downing
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4633ac1d4d2cb6fce0fe2739125a4a6e134e4c2
Gerrit-Change-Number: 7653139
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages