Fix NOTREACHED crash in StreamPacketSocket::SetOption [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Apr 21, 2026, 3:55:25 PM (3 days ago) Apr 21
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 4:15:26 PM (3 days ago) Apr 21
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 21, 2026, 4:15:52 PM (3 days ago) Apr 21
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 6:29:53 PM (2 days ago) Apr 21
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Fix NOTREACHED crash in StreamPacketSocket::SetOption
WebRTC routinely calls SetOption() on transport ports during session
negotiation (e.g., to apply OPT_DSCP or OPT_NODELAY). If the socket was
closed or the option was unsupported, StreamPacketSocket::SetOption()
would hit a NOTREACHED() macro.
Historically, NOTREACHED() was ignored in Chromium Release builds,
allowing the function to fall through and return -1. WebRTC's
AsyncPacketSocket API contract correctly interprets -1 as "option
unsupported" and gracefully continues.
However, Chromium recently changed NOTREACHED() to be fatal in Release
builds (acting like CHECK(false)). This caused the previously benign
fall-through to become a fatal SIGTRAP crash.
This change updates SetOption() to explicitly return -1 in these
expected conditions instead of asserting, conforming to WebRTC's API
contract. A unit test is also added to verify the fix.
Additional unit tests for this class will be added in a follow-up
CL to keep this one scoped to the fix.
Bug: 447155162
Change-Id: I7e755aed97e23845c07b0be03fe663b818c606b5
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618496}
Files:
- M remoting/protocol/BUILD.gn
- M remoting/protocol/stream_packet_socket.cc
- A remoting/protocol/stream_packet_socket_unittest.cc
Change size: S
Delta: 3 files changed, 31 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages