[BNPL][PNPL] Suggestion shown metrics [chromium/src : main]

0 views
Skip to first unread message

Yishui Liu (Gerrit)

unread,
Mar 25, 2026, 5:14:16 PM (9 days ago) Mar 25
to Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Slobodan Pejic and Vinny Persky

Yishui Liu added 1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Yishui Liu . resolved

Hi Vinny and Slobo,

Can you take a look on this CL?

Thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Slobodan Pejic
  • Vinny Persky
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
Gerrit-Change-Number: 7695193
Gerrit-PatchSet: 13
Gerrit-Owner: Yishui Liu <yis...@google.com>
Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
Gerrit-Reviewer: Yishui Liu <yis...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Vinny Persky <vinny...@google.com>
Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
Gerrit-Comment-Date: Wed, 25 Mar 2026 21:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slobodan Pejic (Gerrit)

unread,
Mar 25, 2026, 5:31:34 PM (9 days ago) Mar 25
to Yishui Liu, Vinny Persky, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Vinny Persky and Yishui Liu

Slobodan Pejic added 4 comments

File tools/metrics/histograms/metadata/autofill/histograms.xml
Line 4215, Patchset 14 (Latest): selected, filled, and submitted from suggestion dropdown with tabbed pane,
Slobodan Pejic . unresolved
```suggestion
    selected, filled, and submitted from a suggestion dropdown with a tabbed pane,
```
Line 4215, Patchset 14 (Latest): selected, filled, and submitted from suggestion dropdown with tabbed pane,
Slobodan Pejic . unresolved

"... filled, and submitted ..., and when the... " There are two `and`s here. One here, and in the same sentence the line below.

Line 4217, Patchset 14 (Latest): action occurs (suggestion shown, selected, etc.). Each BnplFormEvent metric
Slobodan Pejic . unresolved

This seems to refer to the enum for the event above. Should it be PayLaterFormEvent?

Line 4218, Patchset 14 (Latest): can be recorded once per page load.
Slobodan Pejic . unresolved

I'm not sure how this records once per page load and also when the BNPL suggestion is shown, selected, filled, submitted, and tab switched.

Open in Gerrit

Related details

Attention is currently required from:
  • Vinny Persky
  • Yishui Liu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
    Gerrit-Change-Number: 7695193
    Gerrit-PatchSet: 14
    Gerrit-Owner: Yishui Liu <yis...@google.com>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
    Gerrit-Reviewer: Yishui Liu <yis...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Vinny Persky <vinny...@google.com>
    Gerrit-Attention: Yishui Liu <yis...@google.com>
    Gerrit-Comment-Date: Wed, 25 Mar 2026 21:31:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yishui Liu (Gerrit)

    unread,
    Mar 25, 2026, 6:18:34 PM (9 days ago) Mar 25
    to Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
    Attention needed from Slobodan Pejic and Vinny Persky

    Yishui Liu added 4 comments

    File tools/metrics/histograms/metadata/autofill/histograms.xml
    Line 4215, Patchset 14: selected, filled, and submitted from suggestion dropdown with tabbed pane,
    Slobodan Pejic . resolved
    ```suggestion
        selected, filled, and submitted from a suggestion dropdown with a tabbed pane,
    ```
    Yishui Liu

    description updated

    Line 4215, Patchset 14: selected, filled, and submitted from suggestion dropdown with tabbed pane,
    Slobodan Pejic . resolved

    "... filled, and submitted ..., and when the... " There are two `and`s here. One here, and in the same sentence the line below.

    Yishui Liu

    Moved the second and part to a new sentence.

    Line 4217, Patchset 14: action occurs (suggestion shown, selected, etc.). Each BnplFormEvent metric
    Slobodan Pejic . resolved

    This seems to refer to the enum for the event above. Should it be PayLaterFormEvent?

    Yishui Liu

    Thanks for catching this. enum name updated.

    Line 4218, Patchset 14: can be recorded once per page load.
    Slobodan Pejic . unresolved

    I'm not sure how this records once per page load and also when the BNPL suggestion is shown, selected, filled, submitted, and tab switched.

    Yishui Liu

    Same as old BNPL metrics, we are using [CreditCardFormEventLogger::has_logged_suggestions_shown_on_bnpl_eligible_merchant_](https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.cc#:~:text=if%20(!has_logged_suggestions_shown_on_bnpl_eligible_merchant_,%7D) to track if this is the first shown event.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Slobodan Pejic
    • Vinny Persky
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
    Gerrit-Change-Number: 7695193
    Gerrit-PatchSet: 16
    Gerrit-Owner: Yishui Liu <yis...@google.com>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
    Gerrit-Reviewer: Yishui Liu <yis...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Vinny Persky <vinny...@google.com>
    Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Comment-Date: Wed, 25 Mar 2026 22:18:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Slobodan Pejic <slob...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Slobodan Pejic (Gerrit)

    unread,
    Mar 26, 2026, 11:04:40 AM (8 days ago) Mar 26
    to Yishui Liu, Vinny Persky, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
    Attention needed from Vinny Persky and Yishui Liu

    Slobodan Pejic added 1 comment

    File tools/metrics/histograms/metadata/autofill/histograms.xml
    Line 4218, Patchset 14: can be recorded once per page load.
    Slobodan Pejic . unresolved

    I'm not sure how this records once per page load and also when the BNPL suggestion is shown, selected, filled, submitted, and tab switched.

    Yishui Liu

    Same as old BNPL metrics, we are using [CreditCardFormEventLogger::has_logged_suggestions_shown_on_bnpl_eligible_merchant_](https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.cc#:~:text=if%20(!has_logged_suggestions_shown_on_bnpl_eligible_merchant_,%7D) to track if this is the first shown event.

    Slobodan Pejic

    BnplFormEvent is logged when shown, selected, filled, submitted. Is the same true for PayLaterFormEvent? It seems to just be on shown.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vinny Persky
    • Yishui Liu
    Gerrit-Attention: Yishui Liu <yis...@google.com>
    Gerrit-Comment-Date: Thu, 26 Mar 2026 15:04:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Slobodan Pejic <slob...@chromium.org>
    Comment-In-Reply-To: Yishui Liu <yis...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yishui Liu (Gerrit)

    unread,
    Mar 26, 2026, 7:04:07 PM (8 days ago) Mar 26
    to Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
    Attention needed from Slobodan Pejic and Vinny Persky

    Yishui Liu added 1 comment

    File tools/metrics/histograms/metadata/autofill/histograms.xml
    Line 4218, Patchset 14: can be recorded once per page load.
    Slobodan Pejic . unresolved

    I'm not sure how this records once per page load and also when the BNPL suggestion is shown, selected, filled, submitted, and tab switched.

    Yishui Liu

    Same as old BNPL metrics, we are using [CreditCardFormEventLogger::has_logged_suggestions_shown_on_bnpl_eligible_merchant_](https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.cc#:~:text=if%20(!has_logged_suggestions_shown_on_bnpl_eligible_merchant_,%7D) to track if this is the first shown event.

    Slobodan Pejic

    BnplFormEvent is logged when shown, selected, filled, submitted. Is the same true for PayLaterFormEvent? It seems to just be on shown.

    Yishui Liu

    There will be more CLs to add the selected, filled, submitted metrics after this CL, and there are [other bool flags](https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.h#:~:text=//%20If%20true%2C%20the%20suggestions,has_logged_form_submitted_with_bnpl_vcn_%20%3D%20false%3B) to make sure those events are only logged once

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Slobodan Pejic
    • Vinny Persky
    Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Comment-Date: Thu, 26 Mar 2026 23:03:58 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Slobodan Pejic (Gerrit)

    unread,
    Mar 30, 2026, 3:26:21 PM (4 days ago) Mar 30
    to Yishui Liu, Vinny Persky, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
    Attention needed from Vinny Persky and Yishui Liu

    Slobodan Pejic voted and added 1 comment

    Votes added by Slobodan Pejic

    Code-Review+1

    1 comment

    File tools/metrics/histograms/metadata/autofill/histograms.xml
    Line 4218, Patchset 14: can be recorded once per page load.
    Slobodan Pejic . resolved

    I'm not sure how this records once per page load and also when the BNPL suggestion is shown, selected, filled, submitted, and tab switched.

    Yishui Liu

    Same as old BNPL metrics, we are using [CreditCardFormEventLogger::has_logged_suggestions_shown_on_bnpl_eligible_merchant_](https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.cc#:~:text=if%20(!has_logged_suggestions_shown_on_bnpl_eligible_merchant_,%7D) to track if this is the first shown event.

    Slobodan Pejic

    BnplFormEvent is logged when shown, selected, filled, submitted. Is the same true for PayLaterFormEvent? It seems to just be on shown.

    Yishui Liu

    There will be more CLs to add the selected, filled, submitted metrics after this CL, and there are [other bool flags](https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.h#:~:text=//%20If%20true%2C%20the%20suggestions,has_logged_form_submitted_with_bnpl_vcn_%20%3D%20false%3B) to make sure those events are only logged once

    Slobodan Pejic

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vinny Persky
    • Yishui Liu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
      Gerrit-Change-Number: 7695193
      Gerrit-PatchSet: 16
      Gerrit-Owner: Yishui Liu <yis...@google.com>
      Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Yishui Liu <yis...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Vinny Persky <vinny...@google.com>
      Gerrit-Attention: Yishui Liu <yis...@google.com>
      Gerrit-Comment-Date: Mon, 30 Mar 2026 19:26:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vinny Persky (Gerrit)

      unread,
      Mar 31, 2026, 3:31:15 PM (3 days ago) Mar 31
      to Yishui Liu, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
      Attention needed from Yishui Liu

      Vinny Persky voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Yishui Liu
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
      Gerrit-Change-Number: 7695193
      Gerrit-PatchSet: 16
      Gerrit-Owner: Yishui Liu <yis...@google.com>
      Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Yishui Liu <yis...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Yishui Liu <yis...@google.com>
      Gerrit-Comment-Date: Tue, 31 Mar 2026 19:31:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vinny Persky (Gerrit)

      unread,
      Mar 31, 2026, 3:31:28 PM (3 days ago) Mar 31
      to Yishui Liu, Stephen McGruer, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
      Attention needed from Stephen McGruer and Yishui Liu

      Vinny Persky added 1 comment

      Patchset-level comments
      File-level comment, Patchset 16 (Latest):
      Vinny Persky . resolved

      LGTM + adding stephen

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Stephen McGruer
      • Yishui Liu
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
      Gerrit-Change-Number: 7695193
      Gerrit-PatchSet: 16
      Gerrit-Owner: Yishui Liu <yis...@google.com>
      Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
      Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Yishui Liu <yis...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
      Gerrit-Attention: Yishui Liu <yis...@google.com>
      Gerrit-Comment-Date: Tue, 31 Mar 2026 19:31:18 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vinny Persky (Gerrit)

      unread,
      Mar 31, 2026, 3:38:20 PM (3 days ago) Mar 31
      to Yishui Liu, Olivia Saul, Stephen McGruer, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
      Attention needed from Olivia Saul, Stephen McGruer and Yishui Liu

      Vinny Persky added 1 comment

      Patchset-level comments
      Vinny Persky . resolved

      Adding Olivia for tools/metrics/histograms

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Olivia Saul
      • Stephen McGruer
      • Yishui Liu
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
      Gerrit-Change-Number: 7695193
      Gerrit-PatchSet: 16
      Gerrit-Owner: Yishui Liu <yis...@google.com>
      Gerrit-Reviewer: Olivia Saul <os...@google.com>
      Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
      Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Yishui Liu <yis...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
      Gerrit-Attention: Yishui Liu <yis...@google.com>
      Gerrit-Attention: Olivia Saul <os...@google.com>
      Gerrit-Comment-Date: Tue, 31 Mar 2026 19:38:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Olivia Saul (Gerrit)

      unread,
      Mar 31, 2026, 4:39:22 PM (3 days ago) Mar 31
      to Yishui Liu, Olivia Saul, Stephen McGruer, Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
      Attention needed from Stephen McGruer and Yishui Liu

      Olivia Saul voted and added 2 comments

      Votes added by Olivia Saul

      Code-Review+1

      2 comments

      Patchset-level comments
      Olivia Saul . resolved

      LGTM for enums.xml and histograms.xml

      File tools/metrics/histograms/metadata/autofill/histograms.xml
      Line 4216, Patchset 16 (Latest): pane. Additionally, Suggstion tab switch events are also tracked. Each event
      Olivia Saul . unresolved

      `Suggestion`

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Stephen McGruer
      • Yishui Liu
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
        Gerrit-Change-Number: 7695193
        Gerrit-PatchSet: 16
        Gerrit-Owner: Yishui Liu <yis...@google.com>
        Gerrit-Reviewer: Olivia Saul <os...@google.com>
        Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
        Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
        Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
        Gerrit-Reviewer: Yishui Liu <yis...@google.com>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
        Gerrit-Attention: Yishui Liu <yis...@google.com>
        Gerrit-Comment-Date: Tue, 31 Mar 2026 20:39:12 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Stephen McGruer (Gerrit)

        unread,
        Mar 31, 2026, 4:56:23 PM (3 days ago) Mar 31
        to Yishui Liu, Stephen McGruer, Olivia Saul, Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
        Attention needed from Yishui Liu

        Stephen McGruer voted and added 1 comment

        Votes added by Stephen McGruer

        Code-Review+1

        1 comment

        Patchset-level comments
        Stephen McGruer . resolved

        components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.{cc,h} LGTM

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Yishui Liu
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
        Gerrit-Change-Number: 7695193
        Gerrit-PatchSet: 16
        Gerrit-Owner: Yishui Liu <yis...@google.com>
        Gerrit-Reviewer: Olivia Saul <os...@google.com>
        Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
        Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
        Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
        Gerrit-Reviewer: Yishui Liu <yis...@google.com>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Yishui Liu <yis...@google.com>
        Gerrit-Comment-Date: Tue, 31 Mar 2026 20:56:08 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Yishui Liu (Gerrit)

        unread,
        Apr 1, 2026, 2:25:32 PM (2 days ago) Apr 1
        to Stephen McGruer, Olivia Saul, Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

        Yishui Liu added 1 comment

        File tools/metrics/histograms/metadata/autofill/histograms.xml
        Line 4216, Patchset 16: pane. Additionally, Suggstion tab switch events are also tracked. Each event
        Olivia Saul . resolved

        `Suggestion`

        Yishui Liu

        typo corrected.

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
          Gerrit-Change-Number: 7695193
          Gerrit-PatchSet: 17
          Gerrit-Owner: Yishui Liu <yis...@google.com>
          Gerrit-Reviewer: Olivia Saul <os...@google.com>
          Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
          Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
          Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
          Gerrit-Reviewer: Yishui Liu <yis...@google.com>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-Comment-Date: Wed, 01 Apr 2026 18:25:19 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Olivia Saul <os...@google.com>
          satisfied_requirement
          open
          diffy

          Yishui Liu (Gerrit)

          unread,
          Apr 1, 2026, 2:25:54 PM (2 days ago) Apr 1
          to Stephen McGruer, Olivia Saul, Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

          Yishui Liu voted Commit-Queue+2

          Commit-Queue+2
          Gerrit-Comment-Date: Wed, 01 Apr 2026 18:25:42 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Yishui Liu (Gerrit)

          unread,
          Apr 1, 2026, 5:07:50 PM (2 days ago) Apr 1
          to Stephen McGruer, Olivia Saul, Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
          Gerrit-Comment-Date: Wed, 01 Apr 2026 21:07:38 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Apr 1, 2026, 7:23:14 PM (2 days ago) Apr 1
          to Yishui Liu, Stephen McGruer, Olivia Saul, Vinny Persky, Slobodan Pejic, (Julie)Jeongeun Kim, Akihiro Ota, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, yuzo+...@chromium.org, ios-r...@chromium.org, dewitt...@chromium.org, chromotin...@chromium.org, marq+...@chromium.org, telemetr...@chromium.org, chromiumme...@microsoft.com, mfoltz+wa...@chromium.org, josiah...@chromium.org, mac-r...@chromium.org, estaab...@chromium.org, extension...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, accessibility-a...@google.com, jdonnel...@chromium.org, chrome-intell...@chromium.org, niharm...@google.com, ios-revie...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, droger+w...@chromium.org, kyungjunle...@google.com, titoua...@chromium.org, chrome-intelligence-te...@google.com, abigailbk...@google.com, filesapp...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

          Chromium LUCI CQ submitted the change with unreviewed changes

          Unreviewed changes

          16 is the latest approved patch-set.
          The change was submitted with unreviewed changes in the following files:

          ```
          The name of the file: tools/metrics/histograms/metadata/autofill/histograms.xml
          Insertions: 3, Deletions: 3.

          @@ -4213,9 +4213,9 @@
               This histogram records events related to Buy Now Pay Later (BNPL)
               suggestions in tabbed pane. It tracks when the BNPL suggestion is shown,

               selected, filled, and submitted from a suggestion dropdown with a tabbed
          -    pane. Additionally, Suggstion tab switch events are also tracked. Each event
          -    log is emitted when the action occurs (suggestion shown, selected, etc.).
          -    Each PayLaterFormEvent metric can be recorded once per page load.
          +    pane. Additionally, suggestion tab switch events are also tracked. Each
          +    event log is emitted when the action occurs (suggestion shown, selected,
          +    etc.). Each PayLaterFormEvent metric can be recorded once per page load.
             </summary>
           </histogram>
           
          ```

          Change information

          Commit message:
          [BNPL][PNPL] Suggestion shown metrics

          This CL adds the logging logic for Pay Later tabs when the suggestions
          are shown on BNPL eligible websites.

          Suggestions shown is always logged as far as the user is on a BNPL
          eligible websites.
          Suggestions shown with pay later tab is only logged when there is a pay
          later tab suggestion.

          Screen record:
          http://screencast/cast/NTM1NTIxNDAyMTMyODg5NnwzZTU5MzU5Zi04Yw
          Bug: 477689220
          Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
          Commit-Queue: Yishui Liu <yis...@google.com>
          Reviewed-by: Vinny Persky <vinny...@google.com>
          Reviewed-by: Olivia Saul <os...@google.com>
          Reviewed-by: Slobodan Pejic <slob...@chromium.org>
          Reviewed-by: Stephen McGruer <smcg...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1608850}
          Files:
          • M components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.cc
          • M components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.h
          • M components/autofill/core/browser/metrics/payments/bnpl_metrics.cc
          • M components/autofill/core/browser/metrics/payments/bnpl_metrics.h
          • M components/autofill/core/browser/metrics/payments/bnpl_metrics_unittest.cc
          • M components/autofill/core/browser/suggestions/payments/credit_card_suggestion_generator.cc
          • M components/autofill/core/browser/suggestions/payments/payments_suggestion_generator_util.h
          • M tools/metrics/histograms/metadata/autofill/enums.xml
          • M tools/metrics/histograms/metadata/autofill/histograms.xml
          Change size: M
          Delta: 9 files changed, 201 insertions(+), 1 deletion(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Slobodan Pejic, +1 by Stephen McGruer, +1 by Vinny Persky, +1 by Olivia Saul
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ice88913d49c2df2b1480637d4bec38c6ac0fdfbb
          Gerrit-Change-Number: 7695193
          Gerrit-PatchSet: 18
          Gerrit-Owner: Yishui Liu <yis...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Olivia Saul <os...@google.com>
          Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
          Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
          Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
          Gerrit-Reviewer: Yishui Liu <yis...@google.com>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages