Reland "Refactor ShouldHonorPolicies to use standard sensitive policy mechanism" [chromium/src : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Jan 12, 2026, 5:51:16 AM (9 days ago) Jan 12
to Przemek Rudziński, Helmut Januschka, Owen Min, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Helmut Januschka, Igor Ruvinov, Julian Pastarmov, Lambros Lambrou and Owen Min
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Helmut Januschka
- Igor Ruvinov
- Julian Pastarmov
- Lambros Lambrou
- Owen Min
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Jan 12, 2026, 7:44:47 AM (8 days ago) Jan 12
to Przemek Rudziński, Rubber Stamper, Helmut Januschka, Owen Min, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Igor Ruvinov, Julian Pastarmov, Lambros Lambrou, Owen Min and Przemek Rudziński
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Helmut Januschka . resolved
hello Przemek, this is a reland?
with owen's last comments, i did: https://chromium-review.googlesource.com/c/chromium/src/+/7414850
(discussion in original CL: https://chromium-review.googlesource.com/c/chromium/src/+/7232257/comment/af0cea0c_e2094cbc/)
is the reland, somehow changed? idk how to diff it
Related details
Attention is currently required from:
- Igor Ruvinov
- Julian Pastarmov
- Lambros Lambrou
- Owen Min
- Przemek Rudziński
Rubber Stamper (Gerrit)
Jan 12, 2026, 9:56:22 AM (8 days ago) Jan 12
to Przemek Rudziński, Helmut Januschka, Owen Min, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Julian Pastarmov, Lambros Lambrou, Owen Min and Przemek Rudziński
Message from Rubber Stamper![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Julian Pastarmov
- Lambros Lambrou
- Owen Min
- Przemek Rudziński
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Owen Min (Gerrit)
Jan 12, 2026, 1:24:42 PM (8 days ago) Jan 12
to Przemek Rudziński, Helmut Januschka, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Julian Pastarmov, Lambros Lambrou and Przemek Rudziński
Owen Min added 2 comments![]( "Open in Gerrit")
File chrome/browser/chrome_content_browser_client.cc
Line 990, Patchset 3 (Latest):
return policy::ManagementServiceFactory::GetForPlatform()Owen Min . unresolved
This should includes macOS too. But let's also wrap it with an experimental as well.
File headless/lib/browser/policy/headless_browser_policy_connector.cc
Line 34, Patchset 3 (Latest):
#include "components/policy/core/common/management/platform_management_service.h"Owen Min . unresolved
This should be included in both win and mac
Related details
Attention is currently required from:
- Julian Pastarmov
- Lambros Lambrou
- Przemek Rudziński
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Jan 12, 2026, 1:26:47 PM (8 days ago) Jan 12
to Przemek Rudziński, Helmut Januschka, Owen Min, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Julian Pastarmov and Przemek Rudziński
Lambros Lambrou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lambros Lambrou
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Julian Pastarmov
- Przemek Rudziński
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Jan 13, 2026, 2:27:56 PM (7 days ago) Jan 13
to Przemek Rudziński, Helmut Januschka, Owen Min, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Julian Pastarmov and Przemek Rudziński
Lambros Lambrou voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Julian Pastarmov
- Przemek Rudziński
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Owen Min (Gerrit)
Jan 13, 2026, 5:51:47 PM (7 days ago) Jan 13
to Przemek Rudziński, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Julian Pastarmov and Przemek Rudziński
Owen Min voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Julian Pastarmov
- Przemek Rudziński
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Owen Min (Gerrit)
Jan 13, 2026, 5:52:10 PM (7 days ago) Jan 13
to Przemek Rudziński, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Julian Pastarmov and Przemek Rudziński
Owen Min added 2 comments![]( "Open in Gerrit")
File chrome/browser/chrome_content_browser_client.cc
This should includes macOS too. But let's also wrap it with an experimental as well.
Owen Min
Resolve
File headless/lib/browser/policy/headless_browser_policy_connector.cc
Line 34, Patchset 3:
#include "components/policy/core/common/management/platform_management_service.h"Owen Min . resolved
This should be included in both win and mac
Owen Min
Resolve
Related details
Attention is currently required from:
- Julian Pastarmov
- Przemek Rudziński
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Przemek Rudziński (Gerrit)
Jan 14, 2026, 5:07:51 AM (7 days ago) Jan 14
to Owen Min, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Attention needed from Julian Pastarmov
Przemek Rudziński voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Julian Pastarmov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Przemek Rudziński (Gerrit)
Jan 14, 2026, 6:00:23 AM (7 days ago) Jan 14
to Owen Min, Lambros Lambrou, Chromium LUCI CQ, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Chromium LUCI CQ (Gerrit)
Jan 14, 2026, 6:22:45 AM (7 days ago) Jan 14
to Przemek Rudziński, Owen Min, Lambros Lambrou, Igor Ruvinov, Julian Pastarmov, AyeAye, Enterprise Policy Reviews, chromium...@chromium.org, chromotin...@chromium.org, mac-r...@chromium.org, headless...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "Refactor ShouldHonorPolicies to use standard sensitive policy mechanism"
This reverts commit d78ee7207df6a41df5dc17d71452a7a39f6b4165.
Reland "Refactor ShouldHonorPolicies to use standard sensitive policy mechanism"
Original change's description:
> Revert "Refactor ShouldHonorPolicies to use standard sensitive policy mechanism"
>
> This reverts commit adfc6d73de03093fa95f70dee9ec09524eae1896.
>
> Reason for revert: This CL changed the behavior of URLBlocklist and
> URLAllowlist but it shouldn't.
>
> Original change's description:
> > Refactor ShouldHonorPolicies to use standard sensitive policy mechanism
> >
> > Refactors the URLAllowlist/URLBlocklist policy protection to use
> > the standard kSensitivePolicies[] mechanism instead of a one-off
> > ShouldHonorPolicies() check.
> >
> > This ensures that when URLAllowlist/URLBlocklist policies are blocked
> > due to an untrusted source, they are visible on chrome://policy with
> > an appropriate error message, rather than being silently ignored.
> >
> > Bug: 40765067, 1322121
> > Change-Id: I1263d8124915e486166283b0897da878d0156619
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7232257
> > Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
> > Reviewed-by: Igor Ruvinov <igorr...@chromium.org>
> > Commit-Queue: Helmut Januschka <hel...@januschka.com>
> > Reviewed-by: Julian Pastarmov <pasta...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1565105}
>
> Bug: 40765067, 1322121
> Change-Id: I20617fb56723b29e6cc2344f2fa8ec176c237aca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7418543
> Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
> Reviewed-by: Owen Min <zm...@chromium.org>
> Reviewed-by: Igor Ruvinov <igorr...@chromium.org>
> Auto-Submit: Owen Min <zm...@chromium.org>
> Reviewed-by: Julian Pastarmov <pasta...@chromium.org>
> Commit-Queue: Lambros Lambrou <lambros...@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1567009}
Bug: 40765067, 1322121
Change-Id: Iff7b9e1626863b584e9057985b32858e66b7eb0e
Commit-Queue: Przemek Rudziński <prudz...@google.com>
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Reviewed-by: Owen Min <zm...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569021}
Files:
- M chrome/browser/chrome_content_browser_client.cc
- M chrome/browser/policy/chrome_browser_policy_connector.cc
- M components/policy/core/common/async_policy_loader.cc
- M components/policy/core/common/features.cc
- M components/policy/core/common/features.h
- M components/policy/core/common/policy_loader_mac.h
- M components/policy/core/common/policy_loader_mac.mm
- M components/policy/core/common/policy_loader_mac_unittest.cc
- M headless/lib/browser/policy/headless_browser_policy_connector.cc
- M remoting/host/policy_watcher.cc
Change size: M
Delta: 10 files changed, 172 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Owen Min, +1 by Lambros Lambrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages