Add Sign function to RsaKeyPair [chromium/src : main]

0 views
Skip to first unread message

Joe Downing (Gerrit)

unread,
Jan 12, 2026, 7:42:12 PM (8 days ago) Jan 12
to Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Joe Downing added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I752a16b8af60327f7d47c0e946eb6ba0f689f126
Gerrit-Change-Number: 7457230
Gerrit-PatchSet: 5
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 00:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
Jan 13, 2026, 12:53:25 PM (7 days ago) Jan 13
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I752a16b8af60327f7d47c0e946eb6ba0f689f126
Gerrit-Change-Number: 7457230
Gerrit-PatchSet: 5
Gerrit-Owner: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 17:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
Jan 13, 2026, 4:19:12 PM (7 days ago) Jan 13
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I752a16b8af60327f7d47c0e946eb6ba0f689f126
    Gerrit-Change-Number: 7457230
    Gerrit-PatchSet: 7
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Joe Downing <joe...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 21:19:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Joe Downing (Gerrit)

    unread,
    Jan 13, 2026, 4:21:46 PM (7 days ago) Jan 13
    to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

    Joe Downing voted and added 1 comment

    Votes added by Joe Downing

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Joe Downing . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I752a16b8af60327f7d47c0e946eb6ba0f689f126
    Gerrit-Change-Number: 7457230
    Gerrit-PatchSet: 7
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 21:21:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 4:25:13 PM (7 days ago) Jan 13
    to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add Sign function to RsaKeyPair

    This CL adds a signing function and tests to the Host RSA KeyPair.
    This function will be used to sign the ECDH ephemeral public key
    provided to the client which the client will validate using the
    host public key.
    Bug: 359620500
    Change-Id: I752a16b8af60327f7d47c0e946eb6ba0f689f126
    Reviewed-by: Yuwei Huang <yuw...@chromium.org>
    Commit-Queue: Joe Downing <joe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568680}
    Files:
    • M remoting/base/rsa_key_pair.cc
    • M remoting/base/rsa_key_pair.h
    • M remoting/base/rsa_key_pair_unittest.cc
    Change size: M
    Delta: 3 files changed, 97 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuwei Huang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I752a16b8af60327f7d47c0e946eb6ba0f689f126
    Gerrit-Change-Number: 7457230
    Gerrit-PatchSet: 8
    Gerrit-Owner: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages