[crd host] Move capturer scheduling logic into DesktopCapturerWrapper [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Feb 19, 2026, 10:06:18 PM (2 days ago) Feb 19
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Feb 20, 2026, 10:19:57 AM (2 days ago) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 20, 2026, 3:51:47 PM (2 days ago) Feb 20
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Yuwei Huang . resolved
Thanks! I'll hold off submission of this CL until the child CL gets approved, since only submitting this CL will break the Windows host.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 5:12:26 PM (2 days ago) Feb 20
to Yuwei Huang, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[crd host] Move capturer scheduling logic into DesktopCapturerWrapper
The scheduling logic is currently in WebrtcVideoStream, which lives in
the network process. This makes it difficult to support Wayland multi-
process hosts since PipeWire capturing is event-driven so no scheduler
is needed, but the network process doesn't know this info without making
an async call to the desktop process.
To fix this, this CL moves the scheduling logic into
DesktopCapturerWrapper, which adapts webrtc::DesktopCapturer into
remoting::DesktopCapturer, and gets rid of the SupportsFrameCallbacks()
method. It might possibly break chromotocol, since it has its own
scheduler.
Additional changes to make this work include:
1. Move DesktopCapturerProxy/Wrapper to remoting/protocol, since they
are needed by connection_unittest.cc
2. Update DesktopCapturerProxy to take remoting::DesktopCapturer instead
of the WebRTC one, so that the extra methods can be proxied.
Bug: 475611769
Change-Id: Iebef9fd3ab0657c92f3ca0058c94672d57d47330
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1588097}
Files:
- M remoting/host/BUILD.gn
- M remoting/host/basic_desktop_environment.cc
- M remoting/host/desktop_and_cursor_conditional_composer.cc
- M remoting/host/desktop_and_cursor_conditional_composer.h
- M remoting/host/fake_desktop_environment.cc
- M remoting/host/legacy_interaction_strategy.cc
- M remoting/host/linux/BUILD.gn
- M remoting/host/linux/gnome_interaction_strategy.cc
- M remoting/host/linux/gnome_interaction_strategy.h
- M remoting/host/linux/pipewire_desktop_capturer.cc
- M remoting/host/linux/pipewire_desktop_capturer.h
- M remoting/host/linux/portal_interaction_strategy.cc
- M remoting/protocol/BUILD.gn
- M remoting/protocol/connection_unittest.cc
- D remoting/protocol/desktop_capturer.cc
- M remoting/protocol/desktop_capturer.h
- R remoting/protocol/desktop_capturer_proxy.cc
- R remoting/protocol/desktop_capturer_proxy.h
- R remoting/protocol/desktop_capturer_wrapper.cc
- R remoting/protocol/desktop_capturer_wrapper.h
- D remoting/protocol/no_op_webrtc_frame_scheduler.cc
- D remoting/protocol/no_op_webrtc_frame_scheduler.h
- M remoting/protocol/webrtc_video_stream.cc
Change size: L
Delta: 23 files changed, 231 insertions(+), 288 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages