[Chromoting] Log any previous crash report ids on launch. [chromium/src : main]
Gary Kacmarcik (Gerrit)
Gary Kacmarcik voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
- Joe Downing
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Code-Review | +1 |
2 comments
lgtm in case you want to land as-is but I think it would be good to ensure we handle the case where a machine is in a crashloop so we don't spam journald with hundreds/thousands of lines on each loop.
status = database_->GetCompletedReports(&completed_reports);I like logging crash info but I'm a bit concerned about the case where there is a crashloop (say a thousand crashes within a short timeframe) and what that would do to the host log and the journal service.
I could see sorting the entries by time and dumping the last N (maybe N = 5) entries along with the total size and then maybe including a flag in the crash_handler exe which dumps everything to the console. WDYT?
Related details
- Gary Kacmarcik
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gary Kacmarcik (Gerrit)
Gary Kacmarcik added 1 comment![]( "Open in Gerrit")
status = database_->GetCompletedReports(&completed_reports);I like logging crash info but I'm a bit concerned about the case where there is a crashloop (say a thousand crashes within a short timeframe) and what that would do to the host log and the journal service.
I could see sorting the entries by time and dumping the last N (maybe N = 5) entries along with the total size and then maybe including a flag in the crash_handler exe which dumps everything to the console. WDYT?
I was planning on removing the completed entries from the database after they were uploaded.
But I'd still need to do something like you suggest for the pending reports, since a crash loop coupled with something that prevents uploads would cause the same scenario you describe.
I'll do this in a follow-up cl.
Related details
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gary Kacmarcik (Gerrit)
Gary Kacmarcik voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[Chromoting] Log any previous crash report ids on launch.
- M remoting/base/crash/crashpad_linux.cc
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |