Yuwei Huang (Gerrit)

unread,

Mar 13, 2026, 3:08:43 PM (yesterday) Mar 13

to Joe Downing, Lambros Lambrou, Jamie Walch, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Attention needed from Joe Downing and Lambros Lambrou

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Yuwei Huang . resolved

PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing
Lambros Lambrou

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Downing (Gerrit)

unread,

Mar 13, 2026, 3:59:28 PM (yesterday) Mar 13

to Yuwei Huang, Lambros Lambrou, Jamie Walch, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Attention needed from Lambros Lambrou and Yuwei Huang

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Code-Review

+1

1 comment

File remoting/host/installer/linux/debian/postinst

Line 93, Patchset 4 (Parent):

      if ! getent group "$CRD_GROUP" > /dev/null 2>&1; then
        addgroup --system "$CRD_GROUP"
      fi

Joe Downing . unresolved

It looks like we no longer need the local chrome-remote-desktop group, in that case we can also clean up the code here: https://source.chromium.org/chromium/chromium/src/+/main:remoting/host/setup/start_host_as_root.cc;drc=f43ed2e1ced0c71bdc11d101a778b9b72eb7f16a;l=46

Open in Gerrit

Related details

Attention is currently required from:

Lambros Lambrou
Yuwei Huang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Mar 13, 2026, 4:37:10 PM (yesterday) Mar 13

to Yuwei Huang, Joe Downing, Jamie Walch, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Attention needed from Yuwei Huang

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Lambros Lambrou . unresolved

Please could you confirm that host setup with start-host still works after your changes?

Open in Gerrit

Related details

Attention is currently required from:

Yuwei Huang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Mar 13, 2026, 5:49:38 PM (23 hours ago) Mar 13

to Yuwei Huang, Joe Downing, Jamie Walch, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Attention needed from Joe Downing and Yuwei Huang

Lambros Lambrou voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing
Yuwei Huang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yuwei Huang (Gerrit)

unread,

Mar 13, 2026, 5:50:22 PM (23 hours ago) Mar 13

to Lambros Lambrou, Joe Downing, Jamie Walch, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Attention needed from Joe Downing

Yuwei Huang voted and added 3 comments

Votes added by Yuwei Huang

Commit-Queue

+2

3 comments

Patchset-level comments

File-level comment, Patchset 4:

Lambros Lambrou . resolved

Please could you confirm that host setup with start-host still works after your changes?

Yuwei Huang

Done. I've confirmed that the `start-host` command still works.

File-level comment, Patchset 6 (Latest):

Yuwei Huang . resolved

Thanks!

File remoting/host/installer/linux/debian/postinst

Line 93, Patchset 4 (Parent):

      if ! getent group "$CRD_GROUP" > /dev/null 2>&1; then
        addgroup --system "$CRD_GROUP"
      fi

Joe Downing . resolved

It looks like we no longer need the local chrome-remote-desktop group, in that case we can also clean up the code here: https://source.chromium.org/chromium/chromium/src/+/main:remoting/host/setup/start_host_as_root.cc;drc=f43ed2e1ced0c71bdc11d101a778b9b72eb7f16a;l=46

Yuwei Huang

Done

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 13, 2026, 6:55:41 PM (22 hours ago) Mar 13

to Yuwei Huang, Lambros Lambrou, Joe Downing, Jamie Walch, chromium...@chromium.org, chromotin...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[crd host][linux] Remove sysvint support

This CL removes the System V init file, the user session binary,
sysv->systemd migration code, host enablement logic in the service
script, etc.

Change was made by gemini-cli then reviewed and verified by me. I built
and installed the the deb package and found no issues using the CRD host
(connection & re-setup host via command line) after the installation.

Bug: 492299120

Change-Id: I8f18ec581053e9c3aaf39de0ffa4b9c9bcac65b0

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7664382

Reviewed-by: Lambros Lambrou <lambros...@chromium.org>

Commit-Queue: Yuwei Huang <yuw...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1599357}

Files:

M remoting/BUILD.gn
M remoting/host/installer/linux/BUILD.gn
M remoting/host/installer/linux/Makefile
D remoting/host/installer/linux/debian/chrome-remote-desktop.init
M remoting/host/installer/linux/debian/postinst
M remoting/host/installer/linux/debian/rules
M remoting/host/linux/BUILD.gn
M remoting/host/linux/linux_me2me_host.py
D remoting/host/linux/remoting_user_session.cc
D remoting/host/linux/remoting_user_session_wrapper.sh
M remoting/host/setup/start_host_as_root.cc

Change size: XL

Delta: 11 files changed, 14 insertions(+), 1548 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lambros Lambrou

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[crd host][linux] Remove sysvint support [chromium/src : main]

Yuwei Huang (Gerrit)

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

1 comment

Related details

Joe Downing (Gerrit)

Joe Downing voted and added 1 comment

Votes added by Joe Downing

1 comment

Related details

Lambros Lambrou (Gerrit)

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

1 comment

Related details

Lambros Lambrou (Gerrit)

Lambros Lambrou voted Code-Review+1

Related details

Yuwei Huang (Gerrit)

Yuwei Huang voted and added 3 comments

Votes added by Yuwei Huang

3 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information