remoting: Introduce allow_gnubby_forwarding session policy [chromium/src : main]
0 views
Skip to first unread message
Yuwei Huang (Gerrit)
Jun 23, 2026, 4:34:57 PM (5 days ago) Jun 23
to Lambros Lambrou, Joe Downing, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Lambros Lambrou
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Lambros Lambrou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Jun 23, 2026, 7:35:30 PM (5 days ago) Jun 23
to Yuwei Huang, Chromium LUCI CQ, Joe Downing, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Lambros Lambrou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lambros Lambrou
| Code-Review | +1 |
1 comment
Commit Message
Line 21, Patchset 3 (Latest):
Bug: 517007701Lambros Lambrou . unresolved
Please could you either add a "b:" prefix, or move the bug to a Chromium bug component?
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Jun 23, 2026, 7:39:01 PM (5 days ago) Jun 23
to Lambros Lambrou, Chromium LUCI CQ, Joe Downing, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Yuwei Huang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Commit Message
Please could you either add a "b:" prefix, or move the bug to a Chromium bug component?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 23, 2026, 7:44:32 PM (5 days ago) Jun 23
to Yuwei Huang, Lambros Lambrou, Joe Downing, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
remoting: Introduce allow_gnubby_forwarding session policy
The goal is to make ClientSession create SecurityKeySession and friends
without having to pass the `security_key_auth_policy_enabled_` bit from
remoting_me2me_host to ClientSession. This CL introduces the
allow_gnubby_forwarding policy to the SessionPolicies struct, which can
be read by ClientSession. This also makes it symmetric to the existing
allow_web_authn_forwarding policy.
Internal change: crrev.com/i/9453783
This CL populates the allow_gnubby_forwarding field but doesn't use it
yet. It will be used in the child CL crrev.com/c/7964054.
Bug: b:517007701
Change-Id: I66e0f7b862df5ee0c228a51c3e14fb925a0b7b6f
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1651374}
Files:
- M remoting/base/cloud_session_authz_service_client_factory.cc
- M remoting/base/session_policies.cc
- M remoting/base/session_policies.h
- M remoting/host/remoting_me2me_host.cc
- M remoting/host/session_policies_from_dict.cc
- M remoting/proto/google/internal/remoting/cloud/v1alpha/session_policies.proto
Change size: S
Delta: 6 files changed, 21 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lambros Lambrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages