Add structs which mirror the new Corp IqStanza messages [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Mar 13, 2026, 8:18:50 PM (19 hours ago) Mar 13
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 13, 2026, 8:29:46 PM (18 hours ago) Mar 13
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 13, 2026, 9:26:58 PM (17 hours ago) Mar 13
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 13, 2026, 10:14:19 PM (17 hours ago) Mar 13
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add structs which mirror the new Corp IqStanza messages
Bug: 359620500
Change-Id: I3a3d51811eed5dac4cc2061a0b031a50a0bd8340
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1599441}
Files:
- M remoting/base/BUILD.gn
- M remoting/internal
- M remoting/proto/BUILD.gn
- M remoting/proto/messaging_service.cc
- M remoting/proto/messaging_service.h
Change size: L
Delta: 5 files changed, 310 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
5:39 AM (9 hours ago) 5:39 AM
to Joe Downing, Chromium LUCI CQ, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Mitsuru Oshima added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Mitsuru Oshima . resolved
Is this intentional? My local repo complains that the submoule commit has difference after this CL.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
8:57 AM (6 hours ago) 8:57 AM
to Joe Downing, Chromium LUCI CQ, Mitsuru Oshima, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Sky Malice added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mitsuru Oshima . unresolved
Is this intentional? My local repo complains that the submoule commit has difference after this CL.
Sky Malice
I'm having the same problem. It looks like this should typically move in lock step with the associated DEPS entry, like in https://crrev.com/c/7667242 or the previous https://crrev.com/c/7595031
I think we should revert this CL.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
8:59 AM (6 hours ago) 8:59 AM
to Joe Downing, Chromium LUCI CQ, Mitsuru Oshima, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Sky Malice has created a revert of this change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages