Fix lifetime issue in DesktopDisplayInfoMonitor observers [chromium/src : main]

0 views
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
May 20, 2026, 7:13:50 PM (23 hours ago) May 20
to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yuwei Huang . resolved

PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I19a0949af15534c1f2d9d340517ff98171fde167
Gerrit-Change-Number: 7865733
Gerrit-PatchSet: 2
Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 23:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
May 20, 2026, 7:21:11 PM (23 hours ago) May 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19a0949af15534c1f2d9d340517ff98171fde167
    Gerrit-Change-Number: 7865733
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Wed, 20 May 2026 23:21:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 20, 2026, 9:17:00 PM (21 hours ago) May 20
    to Yuwei Huang, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix lifetime issue in DesktopDisplayInfoMonitor observers

    DesktopDisplayInfoMonitor::AddCallback now returns a
    CallbackListSubscription. This allows observers to unregister their
    callbacks and prevents potential use-after-free issues when observers
    are destroyed before the monitor.

    TAG=agy
    CONV=abed1b42-36a6-4cc1-92e4-41fe6b47ff73
    Bug: 513789382
    Change-Id: I19a0949af15534c1f2d9d340517ff98171fde167
    Commit-Queue: Yuwei Huang <yuw...@chromium.org>
    Reviewed-by: Joe Downing <joe...@chromium.org>
    Auto-Submit: Yuwei Huang <yuw...@chromium.org>
    Commit-Queue: Joe Downing <joe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1633957}
    Files:
    • M remoting/host/basic_desktop_environment.cc
    • M remoting/host/basic_desktop_environment.h
    • M remoting/host/delegating_desktop_display_info_monitor.cc
    • M remoting/host/delegating_desktop_display_info_monitor.h
    • M remoting/host/delegating_desktop_display_info_monitor_unittest.cc
    • M remoting/host/desktop_display_info_monitor.h
    • M remoting/host/linux/gnome_desktop_display_info_monitor.cc
    • M remoting/host/linux/gnome_desktop_display_info_monitor.h
    • M remoting/host/linux/pipewire_mouse_cursor_capturer.cc
    • M remoting/host/linux/pipewire_mouse_cursor_capturer.h
    • M remoting/host/linux/pipewire_mouse_cursor_capturer_unittest.cc
    • M remoting/host/persistent_display_layout_manager.cc
    • M remoting/host/persistent_display_layout_manager.h
    • M remoting/host/polling_desktop_display_info_monitor.cc
    • M remoting/host/polling_desktop_display_info_monitor.h
    • M remoting/host/resizing_host_observer.cc
    • M remoting/host/resizing_host_observer.h
    • M remoting/host/resizing_host_observer_unittest.cc
    • M remoting/host/webrtc_mouse_cursor_monitor_adaptor_unittest.cc
    • M remoting/host/win/mouse_cursor_monitor_win_unittest.cc
    Change size: M
    Delta: 20 files changed, 62 insertions(+), 30 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joe Downing
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19a0949af15534c1f2d9d340517ff98171fde167
    Gerrit-Change-Number: 7865733
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages