[crd host][linux] Fetch systemd environment for greeters for GDM 49+ [chromium/src : main]

0 views
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
Mar 9, 2026, 7:09:03 PM (5 days ago) Mar 9
to Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Lambros Lambrou

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yuwei Huang . resolved

PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Lambros Lambrou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I111d50414970055b1c1aea6ca62827b18180e2ba
Gerrit-Change-Number: 7649456
Gerrit-PatchSet: 1
Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Comment-Date: Mon, 09 Mar 2026 23:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lambros Lambrou (Gerrit)

unread,
Mar 10, 2026, 1:44:40 PM (4 days ago) Mar 10
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Lambros Lambrou voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I111d50414970055b1c1aea6ca62827b18180e2ba
    Gerrit-Change-Number: 7649456
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Mar 2026 17:44:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yuwei Huang (Gerrit)

    unread,
    Mar 10, 2026, 3:19:12 PM (4 days ago) Mar 10
    to Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
    Attention needed from Lambros Lambrou

    Yuwei Huang voted and added 1 comment

    Votes added by Yuwei Huang

    Auto-Submit+1
    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Yuwei Huang . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Lambros Lambrou
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I111d50414970055b1c1aea6ca62827b18180e2ba
    Gerrit-Change-Number: 7649456
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Mar 2026 19:19:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 10, 2026, 6:04:29 PM (4 days ago) Mar 10
    to Yuwei Huang, Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [crd host][linux] Fetch systemd environment for greeters for GDM 49+

    GDM 49+ switches to temporary greeter users and sets env vars on said
    users' systemd environments. This CL makes CRD always load env vars from
    systemd for GDM 49+, which allows me to test the dynamic user behavior.
    Bug: 488713023
    Change-Id: I111d50414970055b1c1aea6ca62827b18180e2ba
    Commit-Queue: Yuwei Huang <yuw...@chromium.org>
    Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
    Auto-Submit: Yuwei Huang <yuw...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1597353}
    Files:
    • M remoting/host/linux/dbus_interfaces/org_gnome_DisplayManager.h
    • M remoting/host/linux/gdm_remote_display_manager.cc
    • M remoting/host/linux/gdm_remote_display_manager.h
    • M remoting/host/linux/remote_display_session_manager.cc
    • M remoting/tools/run_multi_process_host.py
    Change size: M
    Delta: 5 files changed, 103 insertions(+), 21 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lambros Lambrou
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I111d50414970055b1c1aea6ca62827b18180e2ba
    Gerrit-Change-Number: 7649456
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages