[ContextualTasks] Add debugging input field for Forced Host override [chromium/src : main]

0 views
Skip to first unread message

Duncan Mercer (Gerrit)

unread,
Mar 11, 2026, 10:33:43 PM (3 days ago) Mar 11
to Jerome Jiang, Mirko Bonadei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, devtools...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, cblume...@chromium.org, fgal...@chromium.org, mar...@chromium.org, jshin...@chromium.org, titoua...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, chromotin...@chromium.org, chrome-intell...@chromium.org

Duncan Mercer added 1 comment

File components/contextual_tasks/public/features.cc
Line 11, Patchset 3:#include "base/no_destructor.h"
Duncan Mercer . resolved

remove

Duncan Mercer

Acknowledged

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I36ca82cea8b56b28b9076ffb106d08d3dedd09f6
Gerrit-Change-Number: 7644894
Gerrit-PatchSet: 13
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 02:33:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Mercer <mer...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Duncan Mercer (Gerrit)

unread,
Mar 12, 2026, 12:56:57 PM (2 days ago) Mar 12
to Jerome Jiang, Mirko Bonadei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, devtools...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, cblume...@chromium.org, fgal...@chromium.org, mar...@chromium.org, jshin...@chromium.org, titoua...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, chromotin...@chromium.org, chrome-intell...@chromium.org

Duncan Mercer added 4 comments

File chrome/browser/contextual_tasks/contextual_tasks_internals.mojom
Line 51, Patchset 14 (Latest):<<<<<<< HEAD

// Gets the forced embedded page host.
GetForcedEmbeddedPageHost() => (string host);
=======
>>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
Duncan Mercer . unresolved

Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

File chrome/browser/contextual_tasks/contextual_tasks_internals_page_handler.h
Line 47, Patchset 14 (Latest):<<<<<<< HEAD
void GetForcedEmbeddedPageHost(
GetForcedEmbeddedPageHostCallback callback) override;
=======
>>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
Duncan Mercer . unresolved

Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

File chrome/browser/contextual_tasks/contextual_tasks_internals_page_handler.cc
Line 85, Patchset 14 (Latest):<<<<<<< HEAD
void ContextualTasksInternalsPageHandler::GetForcedEmbeddedPageHost(
GetForcedEmbeddedPageHostCallback callback) {
std::string host;
if (ui_service_) {
host = ui_service_->GetForcedEmbeddedPageHost();
}
std::move(callback).Run(host);
}

=======
>>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
Duncan Mercer . unresolved

Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

File chrome/browser/contextual_tasks/contextual_tasks_navigation_throttle.cc
Line 77, Patchset 14 (Latest):<<<<<<< HEAD
=======
} else {
url = ContextualTasksUiService::GetAimUrlFromContextualTasksUrl(url_params.url, "");
>>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
Duncan Mercer . unresolved

Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36ca82cea8b56b28b9076ffb106d08d3dedd09f6
    Gerrit-Change-Number: 7644894
    Gerrit-PatchSet: 14
    Gerrit-Owner: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 16:56:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Duncan Mercer (Gerrit)

    unread,
    Mar 13, 2026, 12:41:35 PM (yesterday) Mar 13
    to Jerome Jiang, Mirko Bonadei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, devtools...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, cblume...@chromium.org, fgal...@chromium.org, mar...@chromium.org, jshin...@chromium.org, titoua...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, chromotin...@chromium.org, chrome-intell...@chromium.org

    Duncan Mercer added 4 comments

    File chrome/browser/contextual_tasks/contextual_tasks_internals.mojom


    // Gets the forced embedded page host.
    GetForcedEmbeddedPageHost() => (string host);
    =======
    >>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
    Duncan Mercer . resolved

    Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

    Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

    Duncan Mercer

    Done

    File chrome/browser/contextual_tasks/contextual_tasks_internals_page_handler.h

    void GetForcedEmbeddedPageHost(
    GetForcedEmbeddedPageHostCallback callback) override;
    =======
    >>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
    Duncan Mercer . resolved

    Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

    Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

    Duncan Mercer

    Done

    File chrome/browser/contextual_tasks/contextual_tasks_internals_page_handler.cc

    void ContextualTasksInternalsPageHandler::GetForcedEmbeddedPageHost(
    GetForcedEmbeddedPageHostCallback callback) {
    std::string host;
    if (ui_service_) {
    host = ui_service_->GetForcedEmbeddedPageHost();
    }
    std::move(callback).Run(host);
    }

    =======
    >>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
    Duncan Mercer . resolved

    Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

    Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

    Duncan Mercer

    Done

    File chrome/browser/contextual_tasks/contextual_tasks_navigation_throttle.cc

    =======
    } else {
    url = ContextualTasksUiService::GetAimUrlFromContextualTasksUrl(url_params.url, "");
    >>>>>>> 73e5ac246e0d2 ([ContextualTasks] Add debugging input field for Forced Host override)
    Duncan Mercer . resolved

    Please fix this ERROR reported by Conflict Markers: Complete set of conflict markers found. If this is a false alarm, add IGNORE_MER...

    Complete set of conflict markers found. If this is a false alarm, add IGNORE_MERGE_CONFLICT_CHECK==<reason> to your commit message.

    Duncan Mercer

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I36ca82cea8b56b28b9076ffb106d08d3dedd09f6
      Gerrit-Change-Number: 7644894
      Gerrit-PatchSet: 15
      Gerrit-Owner: Duncan Mercer <mer...@google.com>
      Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-CC: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 13 Mar 2026 16:41:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Duncan Mercer <mer...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages