crd: Remove redundant security key headers in host main entry points [chromium/src : main]

0 views
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
Jun 23, 2026, 4:59:28 PM (5 days ago) Jun 23
to android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Yuwei Huang added 7 comments

File remoting/host/desktop_process_main.cc
Line 90, Patchset 2 (Latest): remoting::GetDefaultSecurityKeySocketName());
Yuwei Huang . unresolved

Is this really needed, given the default behavior of `SecurityKeyAuthHandlerPosix::GetSecurityKeySocketName()` is to return `GetDefaultSecurityKeySocketName()`?

File remoting/host/desktop_session_agent.cc
Line 273, Patchset 2 (Latest): security_key_auth_handler_ =
Yuwei Huang . unresolved

Please restore the deleted comment and update it to reflect the change.

File remoting/host/security_key/security_key_auth_handler_posix.cc
Line 60, Patchset 2 (Latest):base::Lock& GetLock() {
Yuwei Huang . unresolved

Maybe call it `GetGlobalResourceLock()` to make it more descriptive.

Line 75, Patchset 2 (Latest):scoped_refptr<base::SequencedTaskRunner> GetFileTaskRunner() {
Yuwei Huang . unresolved

Comment about why we need a global file task runner, i.e. to prevent race condition when deleting files.

Line 80, Patchset 2 (Latest): {base::MayBlock(), base::TaskPriority::USER_VISIBLE,
Yuwei Huang . unresolved

Does it really need to be `USER_VISIBLE`? It is just to delete the socket file during cleanup after all?

File remoting/host/security_key/security_key_extension.h
Line 36, Patchset 2 (Latest): private:
Yuwei Huang . unresolved

Remove empty `private:` section.

File remoting/host/security_key/security_key_extension_session_unittest.cc
Line 30, Patchset 2 (Latest):#if BUILDFLAG(IS_POSIX)
Yuwei Huang . unresolved

Move this below, after all the all-platform includes.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I73614137696759c2eb67682854a7098bab4648a6
Gerrit-Change-Number: 7986591
Gerrit-PatchSet: 2
Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Jun 2026 20:59:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuwei Huang (Gerrit)

unread,
Jun 23, 2026, 5:36:58 PM (5 days ago) Jun 23
to android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Yuwei Huang added 7 comments

File remoting/host/desktop_process_main.cc
Line 90, Patchset 2: remoting::GetDefaultSecurityKeySocketName());
Yuwei Huang . resolved

Is this really needed, given the default behavior of `SecurityKeyAuthHandlerPosix::GetSecurityKeySocketName()` is to return `GetDefaultSecurityKeySocketName()`?

Yuwei Huang

Done

File remoting/host/desktop_session_agent.cc
Line 273, Patchset 2: security_key_auth_handler_ =
Yuwei Huang . resolved

Please restore the deleted comment and update it to reflect the change.

Yuwei Huang

Done

File remoting/host/security_key/security_key_auth_handler_posix.cc
Line 60, Patchset 2:base::Lock& GetLock() {
Yuwei Huang . resolved

Maybe call it `GetGlobalResourceLock()` to make it more descriptive.

Yuwei Huang

Done

Line 75, Patchset 2:scoped_refptr<base::SequencedTaskRunner> GetFileTaskRunner() {
Yuwei Huang . resolved

Comment about why we need a global file task runner, i.e. to prevent race condition when deleting files.

Yuwei Huang

Done

Line 80, Patchset 2: {base::MayBlock(), base::TaskPriority::USER_VISIBLE,
Yuwei Huang . resolved

Does it really need to be `USER_VISIBLE`? It is just to delete the socket file during cleanup after all?

Yuwei Huang

Done

File remoting/host/security_key/security_key_extension.h
Line 36, Patchset 2: private:
Yuwei Huang . resolved

Remove empty `private:` section.

Yuwei Huang

Done

File remoting/host/security_key/security_key_extension_session_unittest.cc
Line 30, Patchset 2:#if BUILDFLAG(IS_POSIX)
Yuwei Huang . resolved

Move this below, after all the all-platform includes.

Yuwei Huang

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I73614137696759c2eb67682854a7098bab4648a6
    Gerrit-Change-Number: 7986591
    Gerrit-PatchSet: 3
    Gerrit-Comment-Date: Tue, 23 Jun 2026 21:36:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Yuwei Huang <yuw...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages