[remoting]: Fix Yoda-style asserts in signaling tests [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Mar 31, 2026, 7:02:27 PM (3 days ago) Mar 31
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 31, 2026, 7:05:54 PM (3 days ago) Mar 31
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File remoting/signaling/ftl_signal_strategy_unittest.cc
Line 540, Patchset 2 (Latest):
ASSERT_EQ(stanza_id, error_message->Attr(kQNameId));Yuwei Huang . unresolved
This line should also be flipped to `ASSERT_EQ(error_message->Attr(kQNameId), stanza_id);` to be consistent with the rest of the changes.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 31, 2026, 7:31:48 PM (3 days ago) Mar 31
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File remoting/signaling/ftl_signal_strategy_unittest.cc
This line should also be flipped to `ASSERT_EQ(error_message->Attr(kQNameId), stanza_id);` to be consistent with the rest of the changes.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 31, 2026, 8:21:08 PM (3 days ago) Mar 31
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: remoting/signaling/ftl_signal_strategy_unittest.cc
Insertions: 3, Deletions: 3.
@@ -537,7 +537,7 @@
ASSERT_EQ(received_messages_.size(), 1u);
auto& error_message = received_messages_[0];
ASSERT_EQ(error_message->Attr(kQNameType), kIqTypeError);
- ASSERT_EQ(stanza_id, error_message->Attr(kQNameId));
+ ASSERT_EQ(error_message->Attr(kQNameId), stanza_id);
ASSERT_EQ(error_message->Attr(kQNameFrom), kFakeRemoteFtlId);
ASSERT_EQ(error_message->Attr(kQNameTo), kFakeLocalFtlId);
}
@@ -764,7 +764,7 @@
EXPECT_CALL(*this, OnSignalingMessage(_, _))
.WillOnce([&](const SignalingAddress& sender_address,
const JingleMessage& received_message) {
- EXPECT_EQ(stanza_id, received_message.message_id);
+ EXPECT_EQ(received_message.message_id, stanza_id);
EXPECT_EQ(sender_address.id(), std::string(kFakeRemoteFtlId));
return true;
});
@@ -793,7 +793,7 @@
EXPECT_CALL(*this, OnSignalingMessage(_, _))
.WillOnce([&](const SignalingAddress& sender_address,
const JingleMessage& received_message) {
- EXPECT_EQ(proto_stanza_id, received_message.message_id);
+ EXPECT_EQ(received_message.message_id, proto_stanza_id);
EXPECT_EQ(sender_address.id(), std::string(kFakeRemoteFtlId));
return true;
});
```
Change information
Commit message:
[remoting]: Fix Yoda-style asserts in signaling tests
This CL flips the arguments of EXPECT_EQ/ASSERT_EQ in remoting/signaling/*test.cc
from (expected, actual) to the more natural (actual, expected) format.
Change-Id: I2d70457a7388e1ee6e886c5e1cba49e50332ca0a
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Auto-Submit: Joe Downing <joe...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608201}
Files:
- M remoting/signaling/corp_message_channel_strategy_unittest.cc
- M remoting/signaling/corp_messaging_client_unittest.cc
- M remoting/signaling/ftl_message_channel_strategy_unittest.cc
- M remoting/signaling/ftl_registration_manager_unittest.cc
- M remoting/signaling/ftl_signal_strategy_unittest.cc
- M remoting/signaling/session_config_unittest.cc
- M remoting/signaling/signaling_address_unittest.cc
- M remoting/signaling/signaling_id_util_unittest.cc
Change size: L
Delta: 8 files changed, 138 insertions(+), 138 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages