Use span-based file API in native_messaging_reader.cc [chromium/src : main]
0 views
Skip to first unread message
Jan Keitel (Gerrit)
Jan 12, 2026, 9:45:59 AM (8 days ago) Jan 12
to Joe Downing, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Joe Downing
Jan Keitel voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Jan 12, 2026, 10:23:14 AM (8 days ago) Jan 12
to Jan Keitel, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Jan Keitel
Joe Downing added 1 comment![]( "Open in Gerrit")
File remoting/host/native_messaging/native_messaging_reader.cc
Line 104, Patchset 1 (Latest):
if (read_result.value_or(0) != 0) {
LOG(ERROR) << "Failed to read message header, read returned "
<< read_result.value_or(0);
}Joe Downing . unresolved
AFAICT this will treat errors as EOF since ReadAtCurrentPos returns nullopt on error so I think it would be better to provide a default of '-1' to indicate error and disambiguate from EOF.
Related details
Attention is currently required from:
- Jan Keitel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jan Keitel (Gerrit)
Jan 13, 2026, 3:13:34 AM (8 days ago) Jan 13
to Joe Downing, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Joe Downing
Jan Keitel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jan Keitel
| Auto-Submit | +1 |
1 comment
File remoting/host/native_messaging/native_messaging_reader.cc
Line 104, Patchset 1:
if (read_result.value_or(0) != 0) {
LOG(ERROR) << "Failed to read message header, read returned "
<< read_result.value_or(0);
}Joe Downing . resolved
AFAICT this will treat errors as EOF since ReadAtCurrentPos returns nullopt on error so I think it would be better to provide a default of '-1' to indicate error and disambiguate from EOF.
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Jan 13, 2026, 9:59:16 AM (7 days ago) Jan 13
to Jan Keitel, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Jan Keitel
Joe Downing voted![]( "Open in Gerrit")
Attention is currently required from:
- Jan Keitel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 13, 2026, 10:02:04 AM (7 days ago) Jan 13
to Jan Keitel, Joe Downing, AyeAye, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use span-based file API in native_messaging_reader.cc
No (intended) functionality changes.
Bug: 435317390
Change-Id: Iabc07f441ea283b172ea23e84daac6ab451aa0a9
Auto-Submit: Jan Keitel <jke...@google.com>
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568377}
Files:
- M remoting/host/native_messaging/native_messaging_reader.cc
Change size: S
Delta: 1 file changed, 16 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages