Fix weird 'RunUntil' replacement for RunUntilIdle [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Mar 11, 2026, 11:41:55 PM (3 days ago) Mar 11
to Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, titoua...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, ortuno...@chromium.org, oshima...@chromium.org
Joe Downing abandoned this change.
Abandoned
Abandoning due to git weirdness
Joe Downing abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 11, 2026, 11:44:05 PM (3 days ago) Mar 11
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, oshima...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 12, 2026, 12:36:59 AM (3 days ago) Mar 12
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, oshima...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Mar 12, 2026, 3:07:46 PM (2 days ago) Mar 12
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, oshima...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Joe Downing . resolved
I've iterated again and I think this is more reliable. I've run a bunch of extra chromeos try-bots and the only failures are because they wren't supposed to be triggered from Gerrit.
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Mar 12, 2026, 4:15:33 PM (2 days ago) Mar 12
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, oshima...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 12, 2026, 4:23:15 PM (2 days ago) Mar 12
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix weird 'RunUntil' replacement for RunUntilIdle
So it turns out the construct that a certain LLM suggested as a
modern improvement over RunUntilIdle (and eloquently defended when
I prodded it for details) is not common and probably didn't do
anything meaningful. I've replaced it with a proper impl :)
Change-Id: Icc096880cb49d1a371bc58186a9e1a3a41ee05aa
Auto-Submit: Joe Downing <joe...@chromium.org>
Commit-Queue: Yuwei Huang <yuw...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1598633}
Files:
- M remoting/host/chromeos/frame_sink_desktop_capturer_unittest.cc
Change size: S
Delta: 1 file changed, 10 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages