Remove XmlElement deps from JingleMessages [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Feb 13, 2026, 1:48:30 PM (9 days ago) Feb 13
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 13, 2026, 5:25:36 PM (8 days ago) Feb 13
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Feb 13, 2026, 5:26:32 PM (8 days ago) Feb 13
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 13, 2026, 5:29:01 PM (8 days ago) Feb 13
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove XmlElement deps from JingleMessages
This CL moves a large chunk of code from ContentDescription into the
XML converter class and then removes the ToXml/FromXml functions
from a few Jingle classes/structs and updates the callsites to use
the XML converter functions.
Bug: 359620500
Change-Id: I5081a65af7aafe79bdd0639d5f93ebebf6cc3d82
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1584917}
Files:
- M remoting/protocol/content_description.cc
- M remoting/protocol/content_description.h
- M remoting/protocol/content_description_unittest.cc
- M remoting/protocol/jingle_message_xml_converter.cc
- M remoting/protocol/jingle_message_xml_converter.h
- M remoting/protocol/jingle_messages.cc
- M remoting/protocol/jingle_messages.h
- M remoting/protocol/jingle_messages_unittest.cc
- M remoting/protocol/jingle_session.cc
- M remoting/protocol/jingle_session_manager.cc
- M remoting/protocol/jingle_session_unittest.cc
Change size: L
Delta: 11 files changed, 212 insertions(+), 308 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages