Use span-based file API in //remoting tests [chromium/src : main]

0 views

Skip to first unread message

Jan Keitel (Gerrit)

unread,

Jan 19, 2026, 4:58:38 AM (yesterday) Jan 19

to Jamie Walch, Chromium LUCI CQ, AyeAye, chromotin...@chromium.org

Attention needed from Jamie Walch

Jan Keitel voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Jamie Walch

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jamie Walch (Gerrit)

unread,

12:50 PM (6 hours ago) 12:50 PM

to Jan Keitel, Chromium LUCI CQ, AyeAye, chromotin...@chromium.org

Attention needed from Jan Keitel

Jamie Walch voted and added 2 comments

Votes added by Jamie Walch

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Jamie Walch . resolved

LGTM with one suggestion.

File remoting/host/it2me/it2me_native_messaging_host_unittest.cc

Line 414, Patchset 4 (Latest): if (read_result != length) {

Jamie Walch . unresolved

Do you need a `has_value` check here? I think the old call would have returned -1, making this comparison safe, but the behaviour is undefined with `std::optional`.