[crd host] Turn REMOTING_MULTI_PROCESS into a boolean [chromium/src : main]

0 views
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
Jan 13, 2026, 10:03:10 PM (7 days ago) Jan 13
to Joe Downing, Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing

Yuwei Huang added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Yuwei Huang . resolved

PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3b41dfd56a2cfcb5244d5a26b86da14d9512470a
Gerrit-Change-Number: 7466723
Gerrit-PatchSet: 3
Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-CC: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 03:02:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
Jan 14, 2026, 12:37:20 PM (6 days ago) Jan 14
to Yuwei Huang, Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Joe Downing voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3b41dfd56a2cfcb5244d5a26b86da14d9512470a
    Gerrit-Change-Number: 7466723
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-CC: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 17:37:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yuwei Huang (Gerrit)

    unread,
    Jan 14, 2026, 3:42:36 PM (6 days ago) Jan 14
    to Joe Downing, Lambros Lambrou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

    Yuwei Huang voted and added 1 comment

    Votes added by Yuwei Huang

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Yuwei Huang . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3b41dfd56a2cfcb5244d5a26b86da14d9512470a
    Gerrit-Change-Number: 7466723
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-CC: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 20:42:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 14, 2026, 3:46:00 PM (6 days ago) Jan 14
    to Yuwei Huang, Joe Downing, Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [crd host] Turn REMOTING_MULTI_PROCESS into a boolean

    The Linux host will need to support both single-process and
    multi-process. This CL replaces the REMOTING_MULTI_PROCESS build flag
    with a boolean, which makes it possible to choose single/multi-process
    mode in runtime. The build flag is only used in remoting_me2me_host.cc.

    This CL should have no behavior changes. I've verified that both the
    Linux host and the Windows host still works after the change.
    Bug: 475611769
    Change-Id: I3b41dfd56a2cfcb5244d5a26b86da14d9512470a
    Reviewed-by: Joe Downing <joe...@chromium.org>
    Commit-Queue: Yuwei Huang <yuw...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1569244}
    Files:
    • M remoting/build/config/BUILD.gn
    • M remoting/host/base/switches.cc
    • M remoting/host/base/switches.h
    • M remoting/host/daemon_process_win.cc
    • M remoting/host/host_main.cc
    • M remoting/host/polling_desktop_display_info_monitor.h
    • M remoting/host/remoting_me2me_host.cc
    • M remoting/remoting_options.gni
    Change size: L
    Delta: 8 files changed, 148 insertions(+), 142 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joe Downing
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3b41dfd56a2cfcb5244d5a26b86da14d9512470a
    Gerrit-Change-Number: 7466723
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages