Replace SignalStrategy::Listener::OnSignalStrategyIncomingStanza [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Feb 19, 2026, 3:30:42 PM (2 days ago) Feb 19
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 19, 2026, 4:11:31 PM (2 days ago) Feb 19
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
Patchset-level comments
Yuwei Huang . resolved
Code looks fine, but you might need to fix JingleSessionTest.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Feb 19, 2026, 6:41:07 PM (2 days ago) Feb 19
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing added 1 comment![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 6:45:32 PM (2 days ago) Feb 19
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: remoting/protocol/jingle_session_manager.cc
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Replace SignalStrategy::Listener::OnSignalStrategyIncomingStanza
This CL replaces the OnSignalStrategyIncomingStanza method on the
SignalStrategy::Listener interface with
SignalStrategy::Listener::OnSignalStrategyIncomingMessage. This is
part of the work to remove the jingle_xmpp dependency in /remoting.
Bug: 359620500
Change-Id: I8f19d9ab62007595f142a3a0d66d1a453910a34b
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587477}
Files:
- M remoting/client/common/remoting_client.cc
- M remoting/client/common/remoting_client.h
- M remoting/host/corp_signaling_connector.cc
- M remoting/host/corp_signaling_connector.h
- M remoting/host/ftl_echo_message_listener.cc
- M remoting/host/ftl_echo_message_listener.h
- M remoting/host/ftl_host_change_notification_listener.cc
- M remoting/host/ftl_host_change_notification_listener.h
- M remoting/host/ftl_signaling_connector.cc
- M remoting/host/ftl_signaling_connector.h
- M remoting/host/heartbeat_sender.cc
- M remoting/host/heartbeat_sender.h
- M remoting/host/passthrough_register_support_host_request.cc
- M remoting/host/passthrough_register_support_host_request.h
- M remoting/host/register_support_host_request_base.cc
- M remoting/host/register_support_host_request_base.h
- M remoting/protocol/jingle_session_manager.cc
- M remoting/protocol/jingle_session_manager.h
- M remoting/signaling/corp_signal_strategy.cc
- M remoting/signaling/corp_signal_strategy_unittest.cc
- M remoting/signaling/fake_signal_strategy.cc
- M remoting/signaling/ftl_signal_strategy.cc
- M remoting/signaling/ftl_signal_strategy.h
- M remoting/signaling/ftl_signal_strategy_unittest.cc
- M remoting/signaling/iq_sender.cc
- M remoting/signaling/iq_sender.h
- M remoting/signaling/iq_sender_unittest.cc
- M remoting/signaling/signal_strategy.cc
- M remoting/signaling/signal_strategy.h
Change size: L
Delta: 29 files changed, 155 insertions(+), 211 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages