Avoid duplicate map lookups. [chromium/src : main]

0 views
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
Mar 27, 2026, 8:19:03 PM (7 days ago) Mar 27
to Jeffrey Yu, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Jeffrey Yu

Yuwei Huang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72156a3c28101b9cf025b85796c613fb37430f83
Gerrit-Change-Number: 7709273
Gerrit-PatchSet: 2
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Sat, 28 Mar 2026 00:18:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jeffrey Yu (Gerrit)

unread,
Mar 30, 2026, 4:09:24 PM (4 days ago) Mar 30
to Joe Downing, Yuwei Huang, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Joe Downing

Jeffrey Yu voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72156a3c28101b9cf025b85796c613fb37430f83
Gerrit-Change-Number: 7709273
Gerrit-PatchSet: 2
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Mar 2026 20:09:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
Mar 30, 2026, 6:58:47 PM (4 days ago) Mar 30
to Jeffrey Yu, Yuwei Huang, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Jeffrey Yu

Joe Downing voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I72156a3c28101b9cf025b85796c613fb37430f83
    Gerrit-Change-Number: 7709273
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Comment-Date: Mon, 30 Mar 2026 22:58:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jeffrey Yu (Gerrit)

    unread,
    Mar 31, 2026, 11:56:16 AM (3 days ago) Mar 31
    to Joe Downing, Yuwei Huang, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org

    Jeffrey Yu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I72156a3c28101b9cf025b85796c613fb37430f83
    Gerrit-Change-Number: 7709273
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Tue, 31 Mar 2026 15:56:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 31, 2026, 12:15:44 PM (3 days ago) Mar 31
    to Jeffrey Yu, Joe Downing, Yuwei Huang, AyeAye, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Avoid duplicate map lookups.

    Instead of using `.count(key)` followed by a lookup, use `.find(key)`,
    and reuse the iterator to access the value.
    Bug: 452950815
    Change-Id: I72156a3c28101b9cf025b85796c613fb37430f83
    Reviewed-by: Joe Downing <joe...@chromium.org>
    Commit-Queue: Jeffrey Yu <yu...@chromium.org>
    Reviewed-by: Yuwei Huang <yuw...@chromium.org>
    Auto-Submit: Jeffrey Yu <yu...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1607906}
    Files:
    • M remoting/host/desktop_resizer_win.cc
    Change size: S
    Delta: 1 file changed, 6 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuwei Huang, +1 by Joe Downing
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I72156a3c28101b9cf025b85796c613fb37430f83
    Gerrit-Change-Number: 7709273
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages