Remove unused Crostini strings (IDS_CROSTINI_*) [chromium/src : main]

0 views
Skip to first unread message

Yoshiki Iguchi (Gerrit)

unread,
Mar 30, 2026, 8:28:05 PM (4 days ago) Mar 30
to Yoshiki Iguchi, Jerome Jiang, Mirko Bonadei, AyeAye, Di Wu, Code Review Nudger, Nicholas Verne, Hidehiko Abe, Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, chromotin...@chromium.org, jz...@chromium.org, grt+...@chromium.org, devtools...@chromium.org
Attention needed from Di Wu and Nicholas Verne

Yoshiki Iguchi voted and added 1 comment

Votes added by Yoshiki Iguchi

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Yoshiki Iguchi . resolved

CR+2 was accidentally removed. Could you approve this again? Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Di Wu
  • Nicholas Verne
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I59b467f1ba31a48a39e8ad73015248b3818f76c7
Gerrit-Change-Number: 7640971
Gerrit-PatchSet: 3
Gerrit-Owner: Yoshiki Iguchi <yos...@chromium.org>
Gerrit-Reviewer: Di Wu <di...@google.com>
Gerrit-Reviewer: Nicholas Verne <nve...@chromium.org>
Gerrit-Reviewer: Yoshiki Iguchi <yos...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Hidehiko Abe <hide...@chromium.org>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jun Ishiguro <ju...@google.com>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Nicholas Verne <nve...@chromium.org>
Gerrit-Attention: Di Wu <di...@google.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 00:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Di Wu (Gerrit)

unread,
Apr 1, 2026, 4:28:58 AM (3 days ago) Apr 1
to Yoshiki Iguchi, Jerome Jiang, Mirko Bonadei, AyeAye, Code Review Nudger, Nicholas Verne, Hidehiko Abe, Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, chromotin...@chromium.org, jz...@chromium.org, grt+...@chromium.org, devtools...@chromium.org
Attention needed from Nicholas Verne and Yoshiki Iguchi

Di Wu voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Verne
  • Yoshiki Iguchi
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I59b467f1ba31a48a39e8ad73015248b3818f76c7
    Gerrit-Change-Number: 7640971
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yoshiki Iguchi <yos...@chromium.org>
    Gerrit-Reviewer: Di Wu <di...@google.com>
    Gerrit-Reviewer: Nicholas Verne <nve...@chromium.org>
    Gerrit-Reviewer: Yoshiki Iguchi <yos...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Hidehiko Abe <hide...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Yoshiki Iguchi <yos...@chromium.org>
    Gerrit-Attention: Nicholas Verne <nve...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 08:28:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yoshiki Iguchi (Gerrit)

    unread,
    Apr 1, 2026, 8:27:09 PM (2 days ago) Apr 1
    to Yoshiki Iguchi, Di Wu, Jerome Jiang, Mirko Bonadei, AyeAye, Code Review Nudger, Nicholas Verne, Hidehiko Abe, Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, chromotin...@chromium.org, jz...@chromium.org, grt+...@chromium.org, devtools...@chromium.org
    Attention needed from Di Wu and Nicholas Verne

    Yoshiki Iguchi voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Di Wu
    • Nicholas Verne
    Gerrit-Attention: Nicholas Verne <nve...@chromium.org>
    Gerrit-Attention: Di Wu <di...@google.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 00:26:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 1, 2026, 8:59:49 PM (2 days ago) Apr 1
    to Yoshiki Iguchi, Di Wu, Jerome Jiang, Mirko Bonadei, AyeAye, Code Review Nudger, Nicholas Verne, Hidehiko Abe, Jun Ishiguro, chromium...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, cblume...@chromium.org, chromotin...@chromium.org, jz...@chromium.org, grt+...@chromium.org, devtools...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove unused Crostini strings (IDS_CROSTINI_*)

    It looks they are no longer used. The build passes without them.
    Bug: 487122295
    Test: CQ passes
    Change-Id: I59b467f1ba31a48a39e8ad73015248b3818f76c7
    Cq-Include-Trybots: luci.chrome.try:chromeos-betty-chrome,chromeos-reven-chrome,linux-chromeos-chrome
    Auto-Submit: Yoshiki Iguchi <yos...@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yos...@chromium.org>
    Reviewed-by: Di Wu <di...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1608904}
    Files:
    • M chrome/app/chromeos_strings.grdp
    • D chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_TITLE_CANCELLED.png.sha1
    • D chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_TITLE_CANCELLED.png.sha1
    • D chrome/app/chromeos_strings_grdp/IDS_CROSTINI_TERMINA_UPDATE_REQUIRED.png.sha1
    Change size: S
    Delta: 4 files changed, 0 insertions(+), 24 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Di Wu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I59b467f1ba31a48a39e8ad73015248b3818f76c7
    Gerrit-Change-Number: 7640971
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yoshiki Iguchi <yos...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Di Wu <di...@google.com>
    Gerrit-Reviewer: Nicholas Verne <nve...@chromium.org>
    Gerrit-Reviewer: Yoshiki Iguchi <yos...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages