Unwind wintrust_shim.h and cryptuiapi_shim.h [chromium/src : main]

0 views
Skip to first unread message

David Benjamin (Gerrit)

unread,
Feb 19, 2026, 7:20:29 PM (2 days ago) Feb 19
to chromotin...@chromium.org, chromium...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, roblia...@chromium.org, wfh+...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, pmonett...@chromium.org, druber...@chromium.org, xinghui...@chromium.org

David Benjamin has uploaded the change for review

Commit message

Unwind wintrust_shim.h and cryptuiapi_shim.h

From the comments, it seems these shims only exist to recursively deal
with wincrypt_shim.h. Now that wincrypt_shim.h is unnecessary, we should
be able to remove these too.
Bug: 483973077
Change-Id: I00dd8437ecd17d47c7591865bfa28df764981973

Change diff


Change information

Files:
  • M base/BUILD.gn
  • M base/win/pe_image_reader.cc
  • M base/win/pe_image_reader_unittest.cc
  • D base/win/wintrust_shim.h
  • M chrome/browser/ui/BUILD.gn
  • D chrome/browser/ui/cryptuiapi_shim.h
  • M chrome/browser/ui/views/certificate_viewer_win.cc
  • M chrome/browser/ui/webui/settings/settings_utils_win.cc
  • M chrome/browser/win/conflicts/module_info_util.cc
  • M chrome/common/safe_browsing/binary_feature_extractor_win.cc
  • M components/device_signals/core/system_signals/win/win_platform_delegate.cc
  • M remoting/host/win/trust_util.cc
Change size: M
Delta: 12 files changed, 15 insertions(+), 52 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I00dd8437ecd17d47c7591865bfa28df764981973
Gerrit-Change-Number: 7595702
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

David Benjamin (Gerrit)

unread,
Feb 19, 2026, 7:22:16 PM (2 days ago) Feb 19
to chromium...@chromium.org, chromotin...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, nwoked...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

David Benjamin voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I00dd8437ecd17d47c7591865bfa28df764981973
Gerrit-Change-Number: 7595702
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 00:22:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
Feb 19, 2026, 8:25:02 PM (2 days ago) Feb 19
to David Benjamin, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, nwoked...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from David Benjamin

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joe Downing . resolved

remoting lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • David Benjamin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I00dd8437ecd17d47c7591865bfa28df764981973
    Gerrit-Change-Number: 7595702
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Attention: David Benjamin <davi...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 01:24:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gabriel Charette (Gerrit)

    unread,
    Feb 20, 2026, 12:35:38 PM (yesterday) Feb 20
    to David Benjamin, David Bienvenu, Eshwar Stalin, Hamda Mare, Lambros Lambrou, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, nwoked...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, Gabriel Charette
    Attention needed from David Benjamin, David Bienvenu, Eshwar Stalin, Hamda Mare and Lambros Lambrou

    Gabriel Charette added 1 comment

    Patchset-level comments
    Gabriel Charette . resolved

    s/gab/davidbienvenu/ as base/win/OWNERS are more appropriate here

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Benjamin
    • David Bienvenu
    • Eshwar Stalin
    • Hamda Mare
    • Lambros Lambrou
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I00dd8437ecd17d47c7591865bfa28df764981973
    Gerrit-Change-Number: 7595702
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Hamda Mare <hm...@google.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Attention: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Attention: David Bienvenu <davidb...@chromium.org>
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Attention: Hamda Mare <hm...@google.com>
    Gerrit-Attention: David Benjamin <davi...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 17:35:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Bienvenu (Gerrit)

    unread,
    Feb 20, 2026, 1:25:21 PM (yesterday) Feb 20
    to David Benjamin, Eshwar Stalin, Hamda Mare, Lambros Lambrou, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, nwoked...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
    Attention needed from David Benjamin, Eshwar Stalin, Hamda Mare and Lambros Lambrou

    David Bienvenu voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Benjamin
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Attention: Hamda Mare <hm...@google.com>
    Gerrit-Attention: David Benjamin <davi...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 18:25:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hamda Mare (Gerrit)

    unread,
    Feb 20, 2026, 1:59:54 PM (yesterday) Feb 20
    to David Benjamin, David Bienvenu, Eshwar Stalin, Lambros Lambrou, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, nwoked...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
    Attention needed from David Benjamin, Eshwar Stalin and Lambros Lambrou

    Hamda Mare voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Benjamin
    • Eshwar Stalin
    • Lambros Lambrou
    Gerrit-Attention: David Benjamin <davi...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 18:59:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages