[crd host][linux] Add SetSharedMemoryFactory support to PipewireDesktopCapturer [chromium/src : main]

0 views
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
Feb 20, 2026, 4:51:50 PM (2 days ago) Feb 20
to Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Lambros Lambrou

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yuwei Huang . resolved

PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Lambros Lambrou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f8663284f58975bbc3fc76de7efd5d0b1b84377
Gerrit-Change-Number: 7597725
Gerrit-PatchSet: 2
Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Lambros Lambrou <lambros...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 21:51:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lambros Lambrou (Gerrit)

unread,
Feb 20, 2026, 4:53:55 PM (2 days ago) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang

Lambros Lambrou voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1f8663284f58975bbc3fc76de7efd5d0b1b84377
    Gerrit-Change-Number: 7597725
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 21:53:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 20, 2026, 6:00:50 PM (2 days ago) Feb 20
    to Yuwei Huang, Lambros Lambrou, chromium...@chromium.org, chromotin...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [crd host][linux] Add SetSharedMemoryFactory support to PipewireDesktopCapturer

    This allows the desktop process to pass the desktop frame to the network
    process. For now I just copy the frame generated by
    SharedScreenCastStream. The plan is to update SharedScreenCastStream so
    that the frame data is just copied once from the PipeWire DMA to the
    shared memory region.
    Bug: 475611769
    Change-Id: I1f8663284f58975bbc3fc76de7efd5d0b1b84377
    Auto-Submit: Yuwei Huang <yuw...@chromium.org>
    Commit-Queue: Yuwei Huang <yuw...@chromium.org>
    Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
    Commit-Queue: Lambros Lambrou <lambros...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1588131}
    Files:
    • M remoting/host/linux/pipewire_desktop_capturer.cc
    • M remoting/host/linux/pipewire_desktop_capturer.h
    • M remoting/host/mojo_video_capturer.cc
    Change size: S
    Delta: 3 files changed, 25 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lambros Lambrou
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1f8663284f58975bbc3fc76de7efd5d0b1b84377
    Gerrit-Change-Number: 7597725
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Lambros Lambrou <lambros...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages