[crd host] Replace SupportsFrameCallbacks() with new async method [chromium/src : main]

[Yuwei Huang (Gerrit)]

Attention needed from Joe Downing

Yuwei Huang added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Yuwei Huang . resolved

PTAL thanks!

File remoting/host/desktop_capturer_proxy.cc

Line 72, Patchset 2 (Latest): requires std::invocable<F, DesktopCapturer*, Args...>

Yuwei Huang . resolved

This is to allow passing function pointers in both `remoting::DesktopCapturer` and `webrtc::DesktopCapturer`. It turns out if an inherited method is not overridden, then clang will think that it is the same as the one in the base class, so the old way will emit weird errors.

Open in Gerrit

Related details

Attention is currently required from:

• Joe Downing

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9bb3fbaafb4b60c762d8732d4be93585df14223b

Gerrit-Change-Number: 7593134

Gerrit-PatchSet: 2

Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>

Gerrit-Reviewer: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Joe Downing <joe...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 09:52:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Joe Downing (Gerrit)]

Attention needed from Yuwei Huang

Joe Downing voted and added 4 comments

Votes added by Joe Downing

Code-Review

+1

4 comments

File remoting/host/ipc_video_frame_capturer.h

Line 48, Patchset 3 (Latest): // webrtc::DesktopCapturer interface.

Joe Downing . unresolved

Not your code but this should be `remoting`.

File remoting/host/linux/gnome_interaction_strategy.h

Line 85, Patchset 3 (Latest): base::OnceCallback<void(std::unique_ptr<remoting::DesktopCapturer>)>>

Joe Downing . unresolved

I don't think this is needed since you're already in the remoting namespace.

File remoting/protocol/desktop_capturer.h

Line 20, Patchset 3 (Latest): enum class CapturerType {

Joe Downing . unresolved

I'm fine using this for now but I do think we should consider cleaning up the IPC model when we no longer support the Chromotocol classes.

Line 20, Patchset 3 (Latest): enum class CapturerType {

Joe Downing . unresolved

Feel free to ack but we already have a desktop_capturer_type in third_party/webrtc/modules/desktop_capture/desktop_capture_types.h.

WDYT about calling this CaptureMode where the values are PUSH or PULL?

Open in Gerrit

Related details

Attention is currently required from:

• Yuwei Huang

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9bb3fbaafb4b60c762d8732d4be93585df14223b

Gerrit-Change-Number: 7593134

Gerrit-PatchSet: 3

Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>

Gerrit-Reviewer: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 20:52:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Yuwei Huang (Gerrit)]

Yuwei Huang added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Yuwei Huang . resolved

Thanks for the review! Based on the comment in crrev.com/c/7590867, I'm probably going to abandon this CL though. The new approach should hopefully eliminate the need for this method.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9bb3fbaafb4b60c762d8732d4be93585df14223b

Gerrit-Change-Number: 7593134

Gerrit-PatchSet: 3

Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>

Gerrit-Reviewer: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Comment-Date: Thu, 19 Feb 2026 21:15:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yuwei Huang (Gerrit)]

Yuwei Huang abandoned this change.

View Change

Abandoned

Yuwei Huang abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon