Fixing a potential race condition in TouchInputInjector [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
May 20, 2026, 12:57:35 PM (yesterday) May 20
to Yuwei Huang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
May 20, 2026, 2:33:30 PM (yesterday) May 20
to Joe Downing, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File remoting/host/input_injector_win.cc
Line 257, Patchset 6 (Latest):
std::unique_ptr<TouchInjectorWin, base::OnTaskRunnerDeleter>Yuwei Huang . resolved
Nice. I didn't know that there is a deleter for deleting an object in a specific task runner :)
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
May 20, 2026, 2:41:06 PM (yesterday) May 20
to Yuwei Huang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 20, 2026, 2:45:15 PM (yesterday) May 20
to Joe Downing, Yuwei Huang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fixing a potential race condition in TouchInputInjector
Move TouchInjectorWin creation and deletion to main_task_runner_.
Bug: 513394258
Change-Id: I8872bcae6012a53c9016395802f4b33f80c294ac
Commit-Queue: Joe Downing <joe...@chromium.org>
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1633732}
Files:
- M remoting/host/input_injector_win.cc
- M remoting/host/touch_injector_win.cc
- M remoting/host/touch_injector_win.h
Change size: S
Delta: 3 files changed, 40 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages