Migrate base::Contains() to std::ranges::contains() in remoting [chromium/src : main]

0 views
Skip to first unread message

Joe Downing (Gerrit)

unread,
Jan 13, 2026, 9:58:01 AM (7 days ago) Jan 13
to Victor Vianna, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Victor Vianna

Joe Downing voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9db85793a1024bae86398adbd3d79d0377a2467
Gerrit-Change-Number: 7460743
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 14:57:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Jan 13, 2026, 10:44:39 AM (7 days ago) Jan 13
to Joe Downing, AyeAye, Chromium LUCI CQ, chromotin...@chromium.org
Attention needed from Joe Downing

Victor Vianna voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9db85793a1024bae86398adbd3d79d0377a2467
Gerrit-Change-Number: 7460743
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 15:44:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 13, 2026, 10:48:11 AM (7 days ago) Jan 13
to Victor Vianna, Joe Downing, AyeAye, chromotin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Migrate base::Contains() to std::ranges::contains() in remoting

base::Contains() is an alias to std::ranges::contains() since
crrev.com/c/7415207, so this CL has no behavior change.
Bug: 470391351
Change-Id: Ib9db85793a1024bae86398adbd3d79d0377a2467
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Victor Vianna <victor...@google.com>
Cr-Commit-Position: refs/heads/main@{#1568402}
Files:
  • M remoting/base/capabilities.cc
  • M remoting/host/client_session.cc
  • M remoting/host/client_session_unittest.cc
  • M remoting/host/linux/clipboard_gnome.cc
  • M remoting/host/linux/gnome_headless_detector.cc
  • M remoting/host/setup/start_host_as_root.cc
  • M remoting/protocol/negotiating_client_authenticator.cc
  • M remoting/protocol/negotiating_host_authenticator.cc
  • M remoting/protocol/session_config.cc
Change size: S
Delta: 9 files changed, 23 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joe Downing
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9db85793a1024bae86398adbd3d79d0377a2467
Gerrit-Change-Number: 7460743
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages