Revert "Add structs which mirror the new Corp IqStanza messages" [chromium/src : main]
0 views
Skip to first unread message
Sky Malice (Gerrit)
8:58 AM (6 hours ago) 8:58 AM
to Joe Downing, Chromium LUCI CQ, Yuwei Huang, chromotin...@chromium.org, chromium...@chromium.org, Mitsuru Oshima
Attention needed from Joe Downing and Yuwei Huang
Sky Malice has uploaded the change for review![]( "Open in Gerrit")
Sky Malice would like Joe Downing, Chromium LUCI CQ and Yuwei Huang to review this change.
Commit message
Revert "Add structs which mirror the new Corp IqStanza messages"
This reverts commit 3df2023e070772d142fa79392b7682e374d84550.
Reason for revert: Modified remoting/internal gitlink without associated DEPS entry change.
Original change's description:
> Add structs which mirror the new Corp IqStanza messages
>
> Bug: 359620500
> Change-Id: I3a3d51811eed5dac4cc2061a0b031a50a0bd8340
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7666646
> Reviewed-by: Yuwei Huang <yuw...@chromium.org>
> Commit-Queue: Joe Downing <joe...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1599441}
Bug: 359620500
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ib452c6d9e2e4c5438e33181e7199575573ee8ea7
Change diff
Change information
Files:
- M remoting/base/BUILD.gn
- M remoting/internal
- M remoting/proto/BUILD.gn
- M remoting/proto/messaging_service.cc
- M remoting/proto/messaging_service.h
Change size: L
Delta: 5 files changed, 3 insertions(+), 310 deletions(-)
Related details
Attention is currently required from:
- Joe Downing
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
8:59 AM (6 hours ago) 8:59 AM
to Sky Malice, Joe Downing, Chromium LUCI CQ, Yuwei Huang, chromotin...@chromium.org, chromium...@chromium.org, Mitsuru Oshima
Attention needed from Joe Downing and Yuwei Huang
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Joe Downing
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
9:10 AM (6 hours ago) 9:10 AM
to Rubber Stamper, Joe Downing, Chromium LUCI CQ, Yuwei Huang, chromotin...@chromium.org, chromium...@chromium.org, Mitsuru Oshima
Attention needed from Joe Downing and Yuwei Huang
Sky Malice voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Joe Downing
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
12:40 PM (2 hours ago) 12:40 PM
to Sky Malice, Rubber Stamper, Chromium LUCI CQ, Yuwei Huang, chromotin...@chromium.org, chromium...@chromium.org, Mitsuru Oshima
Attention needed from Sky Malice and Yuwei Huang
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Code-Review | -1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joe Downing . resolved
Can we roll-forward instead?
Sorry about the git snafu where it pulled in the submodule change, I'm not sure how the original change passed the try-bots before I landed it.
Related details
Attention is currently required from:
- Sky Malice
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
1:43 PM (1 hour ago) 1:43 PM
to Joe Downing, Rubber Stamper, Chromium LUCI CQ, Yuwei Huang, chromotin...@chromium.org, chromium...@chromium.org, Mitsuru Oshima
Sky Malice abandoned this change.
Abandoned
Rolling forward instead in https://crrev.com/c/7668342
Sky Malice abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
1:45 PM (1 hour ago) 1:45 PM
to Joe Downing, Rubber Stamper, Chromium LUCI CQ, Yuwei Huang, chromotin...@chromium.org, chromium...@chromium.org, Mitsuru Oshima
Sky Malice added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Joe Downing . resolved
Can we roll-forward instead?
Sorry about the git snafu where it pulled in the submodule change, I'm not sure how the original change passed the try-bots before I landed it.
Sky Malice
Sounds good, thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages