[remoting] Decouple task runner and policy from SecurityKeyAuthHandler [chromium/src : main]

0 views

Skip to first unread message

unread,

Jun 22, 2026, 8:53:25 PM (6 days ago) Jun 22

to chromium...@chromium.org, chromotin...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Yuwei Huang added 5 comments

File remoting/host/desktop_process_main.cc

Line 93, Patchset 3 (Latest): remoting::SecurityKeyAuthHandler::Init(std::move(options));

Yuwei Huang . unresolved

Why do you only call `Init` for POSIX? It is possible that we later add init options specifically for Windows.

File remoting/host/desktop_session_agent.cc

Line 275, Patchset 3 (Latest): io_task_runner_, SecurityKeyAuthHandler::GetSocketName());

Yuwei Huang . unresolved

Why do you need to pass this? Is this for testing? If so, can you make this optional and defaulted to `GetSocketName()`?

File remoting/host/remoting_me2me_host.cc

Line 1138, Patchset 3 (Latest): security_key_extension_supported_ = false;

Yuwei Huang . unresolved

Is the `security_key_extension_supported_` variable still needed, or can it be removed?

File remoting/host/security_key/security_key_auth_handler.h

Line 39, Patchset 3 (Latest): // Initializes the global configuration. Should be called at host startup.

Yuwei Huang . unresolved

"Must be called before `Create` is called."

File remoting/host/session_policies_from_dict.cc

Line 75, Patchset 3 (Latest): session_policies.allow_gnubby_forwarding =

Yuwei Huang . unresolved

Please also add this to remoting/proto/google/internal/remoting/cloud/v1alpha/session_policies.proto and add the conversion logic.

Attention set is empty

Submit Requirements:

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages