Use management trustworthiness for Mac policy gating [chromium/src : main]
Owen Min (Gerrit)
Owen Min added 1 comment![]( "Open in Gerrit")
Hi Helmut,
Thank you for your contributions. The previous CL effectively addressed long-standing technical debt within the codebase, and this CL resolves the issues raised in my previous comments.
Unfortunately, your work has overlapped with a SWE on my team, as you were both addressing the same issue. I apologize that the bug was not assigned in a timely manner to prevent this conflict.
While both CLs are of excellent quality, I have opted to move forward with the other one due to its inclusion of additional unit tests. However, your work remains commendable and is greatly appreciated.
I hope this conflict does not diminish your enthusiasm for contributing, and your future work remains highly valued.
Regards,
Owen Min
Related details
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Hi Helmut,
Thank you for your contributions. The previous CL effectively addressed long-standing technical debt within the codebase, and this CL resolves the issues raised in my previous comments.
Unfortunately, your work has overlapped with a SWE on my team, as you were both addressing the same issue. I apologize that the bug was not assigned in a timely manner to prevent this conflict.
While both CLs are of excellent quality, I have opted to move forward with the other one due to its inclusion of additional unit tests. However, your work remains commendable and is greatly appreciated.
I hope this conflict does not diminish your enthusiasm for contributing, and your future work remains highly valued.
Regards,
Owen Min
no worries, all good, saw it was done by working on a reland of mine, so atleast it was not completely useless 😊 - so we can abandon this CL here?
Related details
- Owen Min
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Owen Min (Gerrit)
Owen Min added 1 comment![]( "Open in Gerrit")
Helmut JanuschkaHi Helmut,
Thank you for your contributions. The previous CL effectively addressed long-standing technical debt within the codebase, and this CL resolves the issues raised in my previous comments.
Unfortunately, your work has overlapped with a SWE on my team, as you were both addressing the same issue. I apologize that the bug was not assigned in a timely manner to prevent this conflict.
While both CLs are of excellent quality, I have opted to move forward with the other one due to its inclusion of additional unit tests. However, your work remains commendable and is greatly appreciated.
I hope this conflict does not diminish your enthusiasm for contributing, and your future work remains highly valued.
Regards,
Owen Min
no worries, all good, saw it was done by working on a reland of mine, so atleast it was not completely useless 😊 - so we can abandon this CL here?
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |