Victor Vianna (Gerrit)

unread,

Jan 13, 2026, 1:30:54 PM (7 days ago) Jan 13

to Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Victor Vianna added 1 comment

File base/containers/enum_set_nocompile.nc

Line 26, Patchset 10 (Latest): // expected-error@base/containers/enum_set.h:198 {{shift count >= width of type}}

Victor Vianna . unresolved

todo: Figure out if this is okay

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 13, 2026, 1:51:19 PM (7 days ago) Jan 13

to Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Attention needed from Victor Vianna

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

Commit-Queue

+1

1 comment

File base/containers/enum_set_nocompile.nc

Line 26, Patchset 10: // expected-error@base/containers/enum_set.h:198 {{shift count >= width of type}}

Victor Vianna . resolved

todo: Figure out if this is okay

Victor Vianna

Done

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 13, 2026, 3:39:12 PM (7 days ago) Jan 13

to Nico Weber, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Attention needed from Nico Weber

Victor Vianna voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Jan 14, 2026, 1:36:02 PM (6 days ago) Jan 14

to Victor Vianna, Nico Weber, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Attention needed from Victor Vianna

Nico Weber voted and added 4 comments

Votes added by Nico Weber

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Nico Weber . resolved

ty!

File base/allocator/partition_allocator/src/partition_alloc/pointers/instance_tracer.h

Line 55, Patchset 11 (Latest): if consteval {

Nico Weber . unresolved

same

Line 46, Patchset 11 (Latest): if consteval {

Nico Weber . unresolved

This is shorter on the lhs, maybe keep this? Is there a benefit to changing this?

File styleguide/c++/c++-features.md

Line 1778, Patchset 11 (Latest):[Discussion thread](https://groups.google.com/a/chromium.org/g/cxx/c/1e90vNHYVFc)

Nico Weber . resolved

Do you think we should paste jdoerrie's reply verbatim here? I.e. insert

```
This removes a bit gotcha with std::is_constant_evaluated(), which needs to be used with a runtime if (rather than constexpr if) to be meaningful: https://en.cppreference.com/w/cpp/types/is_constant_evaluated.html#Notes
```

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 14, 2026, 3:46:46 PM (6 days ago) Jan 14

to Nico Weber, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Victor Vianna voted and added 4 comments

Votes added by Victor Vianna

Auto-Submit

+1

4 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Victor Vianna . resolved

Thanks!

File base/allocator/partition_allocator/src/partition_alloc/pointers/instance_tracer.h

Line 55, Patchset 11: if consteval {

Nico Weber . resolved

same

Victor Vianna

Done

Line 46, Patchset 11: if consteval {

Nico Weber . resolved

This is shorter on the lhs, maybe keep this? Is there a benefit to changing this?

Victor Vianna

Done

File styleguide/c++/c++-features.md

Line 1778, Patchset 11:[Discussion thread](https://groups.google.com/a/chromium.org/g/cxx/c/1e90vNHYVFc)

Nico Weber . resolved

Do you think we should paste jdoerrie's reply verbatim here? I.e. insert
```
This removes a bit gotcha with std::is_constant_evaluated(), which needs to be used with a runtime if (rather than constexpr if) to be meaningful: https://en.cppreference.com/w/cpp/types/is_constant_evaluated.html#Notes
```

Victor Vianna

Done, added this to Description above

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 14, 2026, 3:46:49 PM (6 days ago) Jan 14

to Nico Weber, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Victor Vianna voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 14, 2026, 3:48:02 PM (6 days ago) Jan 14

to Joe Downing, Nico Weber, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Attention needed from Joe Downing

Victor Vianna added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Victor Vianna . resolved

+joedow@ for //remoting

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Jan 14, 2026, 5:15:52 PM (6 days ago) Jan 14

to Victor Vianna, Joe Downing, Nico Weber, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Attention needed from Joe Downing and Victor Vianna

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Lambros Lambrou . resolved

lgtm for remoting

Open in Gerrit

Related details

Attention is currently required from:

Joe Downing
Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 14, 2026, 5:38:34 PM (6 days ago) Jan 14

to Victor Vianna, Lambros Lambrou, Joe Downing, Nico Weber, Kentaro Hara, AyeAye, chromium...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, chromotin...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[styleguide] Allow if consteval

https://groups.google.com/a/chromium.org/g/cxx/c/1e90vNHYVFc

And migrate some usages of std::is_constant_evaluated.

Change-Id: Idacb89ec5aca1e876b303676c0d4b4f502bc341b

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7378823

Auto-Submit: Victor Vianna <victor...@google.com>

Commit-Queue: Lambros Lambrou <lambros...@chromium.org>

Reviewed-by: Lambros Lambrou <lambros...@chromium.org>

Reviewed-by: Nico Weber <tha...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1569345}

Files:

M PRESUBMIT.py
M base/allocator/partition_allocator/src/partition_alloc/pointers/instance_tracer.h
M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_asan_unowned_impl.h
M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_backup_ref_impl.h
M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_hookable_impl.h
M base/containers/span.h
M base/numerics/basic_ops_impl.h
M remoting/host/linux/gvariant_ref.h
M styleguide/c++/c++-features.md

Change size: M

Delta: 9 files changed, 55 insertions(+), 60 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lambros Lambrou, +1 by Nico Weber

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[styleguide] Allow if consteval [chromium/src : main]

Victor Vianna (Gerrit)

Victor Vianna added 1 comment

Related details

Victor Vianna (Gerrit)

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

1 comment

Related details

Victor Vianna (Gerrit)

Victor Vianna voted Auto-Submit+1

Related details

Nico Weber (Gerrit)

Nico Weber voted and added 4 comments

Votes added by Nico Weber

4 comments

Related details

Victor Vianna (Gerrit)

Victor Vianna voted and added 4 comments

Votes added by Victor Vianna

4 comments

Related details

Victor Vianna (Gerrit)

Victor Vianna voted Commit-Queue+2

Related details

Victor Vianna (Gerrit)

Victor Vianna added 1 comment

Related details

Lambros Lambrou (Gerrit)

Lambros Lambrou voted and added 1 comment

Votes added by Lambros Lambrou

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information