Reland "[LiteRT] Package and install libLiteRtWebGpuAccelerator.so on Linux." [chromium/src : main]
0 views
Skip to first unread message
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jun 23, 2026, 11:32:42 PM (5 days ago) Jun 23
to Lynne Jiang, Lei Zhang, Lambros Lambrou, Taiyo Mizuhashi, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lambros Lambrou, Lei Zhang, Reilly Grant, Taiyo Mizuhashi and Yuwei Huang
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Lambros Lambrou
- Lei Zhang
- Reilly Grant
- Taiyo Mizuhashi
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jun 23, 2026, 11:37:32 PM (5 days ago) Jun 23
to Lynne Jiang, Lei Zhang, Lambros Lambrou, Taiyo Mizuhashi, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lambros Lambrou, Lei Zhang, Reilly Grant, Taiyo Mizuhashi and Yuwei Huang
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Lambros Lambrou
- Lei Zhang
- Reilly Grant
- Taiyo Mizuhashi
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 1:47:17 AM (5 days ago) Jun 24
to Lynne Jiang, Taiyo Mizuhashi, Lei Zhang, Lambros Lambrou, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lambros Lambrou, Lynne Jiang, Reilly Grant and Yuwei Huang
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lei Zhang . resolved
Instead of reverting a revert, try using Gerrit's reland button on your original CL.
Related details
Attention is currently required from:
- Lambros Lambrou
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Jun 24, 2026, 1:08:51 PM (5 days ago) Jun 24
to Lynne Jiang, Taiyo Mizuhashi, Lei Zhang, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lynne Jiang, Reilly Grant and Yuwei Huang
Lambros Lambrou voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Jun 24, 2026, 2:19:29 PM (4 days ago) Jun 24
to Lynne Jiang, Lei Zhang, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lei Zhang, Lynne Jiang, Reilly Grant and Yuwei Huang
Lambros Lambrou voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 2:22:11 PM (4 days ago) Jun 24
to Lynne Jiang, Lambros Lambrou, Lei Zhang, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lynne Jiang, Reilly Grant and Yuwei Huang
Lei Zhang added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved
Please run the Linux Chrome-branded trybot and make sure that passes.
Commit Message
Line 9, Patchset 1 (Latest):
This is a reland of commit c4da94cf2e1199acfb4ffe22cfe2f809a8cb1732Lei Zhang . unresolved
Describe what changed so this reland CL will land safely.
Related details
Attention is currently required from:
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lambros Lambrou (Gerrit)
Jun 24, 2026, 2:23:44 PM (4 days ago) Jun 24
to Lynne Jiang, Lei Zhang, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lei Zhang, Lynne Jiang, Reilly Grant and Yuwei Huang
Lambros Lambrou voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Lei Zhang
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 2:26:24 PM (4 days ago) Jun 24
to Lynne Jiang, Lambros Lambrou, Lei Zhang, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lynne Jiang, Reilly Grant and Yuwei Huang
Lei Zhang added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved
Please run the Linux Chrome-branded trybot and make sure that passes.
Commit Message
Line 9, Patchset 1 (Latest):
This is a reland of commit c4da94cf2e1199acfb4ffe22cfe2f809a8cb1732Lei Zhang . unresolved
Describe what changed so this reland CL will land safely.
Line 9, Patchset 1 (Latest):
This is a reland of commit c4da94cf2e1199acfb4ffe22cfe2f809a8cb1732Lei Zhang . unresolved
Not sure how this commit hash got here, but it's incorrect and doesn't match the hash for crrev.com/1651420
Related details
Attention is currently required from:
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 2:32:44 PM (4 days ago) Jun 24
to Lynne Jiang, Lambros Lambrou, Lei Zhang, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lynne Jiang, Reilly Grant and Yuwei Huang
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lei Zhang . resolved
For next time, it would be best practice to create the reland CL with the original CL as patchset 1, and then build on top of that. Since it is likely that the original CL just needs a little bit of additional work to reland safely. Then reviewers can just look at the diff between patchset 1 and the latest patchset.
Related details
Attention is currently required from:
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lynne Jiang (Gerrit)
Jun 24, 2026, 4:05:11 PM (4 days ago) Jun 24
to Lambros Lambrou, Lei Zhang, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lei Zhang
Lynne Jiang added 4 comments![]( "Open in Gerrit")
Patchset-level comments
Lei Zhang . resolved
Please run the Linux Chrome-branded trybot and make sure that passes.
Lynne Jiang
Done
Lei Zhang . resolved
For next time, it would be best practice to create the reland CL with the original CL as patchset 1, and then build on top of that. Since it is likely that the original CL just needs a little bit of additional work to reland safely. Then reviewers can just look at the diff between patchset 1 and the latest patchset.
Lynne Jiang
That's what I tried to do, but the 'Reland' feature automatically sent out for review even when I opt out so the reviewer were notified before I got the chance to update the cl, apologies for that.
Commit Message
Line 9, Patchset 1:
This is a reland of commit c4da94cf2e1199acfb4ffe22cfe2f809a8cb1732Lei Zhang . resolved
Describe what changed so this reland CL will land safely.
Lynne Jiang
Done
Line 9, Patchset 1:
This is a reland of commit c4da94cf2e1199acfb4ffe22cfe2f809a8cb1732Lei Zhang . resolved
Not sure how this commit hash got here, but it's incorrect and doesn't match the hash for crrev.com/1651420
Lynne Jiang
Updated the commit message. Looks like that the 'Reland' tool produced a CL that did not match my previous submission (I've tried multiple times all give me the wrong one), so I have manually reconciled the content. I am not sure if these are known issues with the tool.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 4:10:32 PM (4 days ago) Jun 24
to Lynne Jiang, Lei Zhang, Lambros Lambrou, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Lynne Jiang, Reilly Grant and Yuwei Huang
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
Commit Message
Line 9, Patchset 1:
This is a reland of commit c4da94cf2e1199acfb4ffe22cfe2f809a8cb1732Lei Zhang . resolved
Not sure how this commit hash got here, but it's incorrect and doesn't match the hash for crrev.com/1651420
Lynne Jiang
Updated the commit message. Looks like that the 'Reland' tool produced a CL that did not match my previous submission (I've tried multiple times all give me the wrong one), so I have manually reconciled the content. I am not sure if these are known issues with the tool.
Lei Zhang
Thanks for trying. Not sure why it's going wrong. From what I remember, it didn't used to have this issue.
Related details
Attention is currently required from:
- Lynne Jiang
- Reilly Grant
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lynne Jiang (Gerrit)
Jun 24, 2026, 4:17:53 PM (4 days ago) Jun 24
to Lei Zhang, Lambros Lambrou, Chromium LUCI CQ, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Attention needed from Reilly Grant and Yuwei Huang
Lynne Jiang voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Reilly Grant
- Yuwei Huang
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 4:21:19 PM (4 days ago) Jun 24
to Lynne Jiang, Lei Zhang, Lambros Lambrou, Reilly Grant, Yuwei Huang, android-bu...@system.gserviceaccount.com, Michael Moss, Joe Downing, Raphael Kubo da Costa, Fumitoshi Ukai, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[LiteRT] Package and install libLiteRtWebGpuAccelerator.so on Linux."
This is a reland of commit dd0907ef67519085152a07c5da01d18967218dbf
Fixed the deps to explicitly depend on ml_drift_webgpu_accelerator_so.
Original change's description:
> [LiteRT] Package and install libLiteRtWebGpuAccelerator.so on Linux.
>
> This library is included in the Chrome and Remoting Linux installers
> when build_with_internal_optimization_guide is enabled, alongside
> liboptimization_guide_internal.so.
>
> Bug: 525135572
> Change-Id: I7e7b831b64a9af8081af35ba6a9da57d8e162415
Bug: 525135572
Change-Id: I0228ec046c977821fe09599029601e7abb7b9fbd
Commit-Queue: Lynne Jiang <lyj...@google.com>
Reviewed-by: Lei Zhang <the...@chromium.org>
Reviewed-by: Lambros Lambrou <lambros...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1651945}
Files:
- M chrome/BUILD.gn
- M chrome/installer/linux/BUILD.gn
- M chrome/installer/linux/common/installer.py
- M remoting/host/installer/linux/installer.include
Change size: S
Delta: 4 files changed, 42 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang, +1 by Lambros Lambrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages