Expand test coverage for StreamPacketSocket [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Apr 21, 2026, 7:02:40 PM (2 days ago) Apr 21
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Apr 21, 2026, 7:15:13 PM (2 days ago) Apr 21
to Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
1 comment
File remoting/protocol/stream_packet_socket_unittest.cc
Line 191, Patchset 4 (Latest):
.WillOnce([&](net::IOBuffer* buf, int buf_len,Yuwei Huang . unresolved
This lambda doesn't need to capture anything, so `[]` is preferred over `[&]`.
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Apr 21, 2026, 7:36:39 PM (2 days ago) Apr 21
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File remoting/protocol/stream_packet_socket_unittest.cc
This lambda doesn't need to capture anything, so `[]` is preferred over `[&]`.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 8:08:38 PM (2 days ago) Apr 21
to Joe Downing, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: remoting/protocol/stream_packet_socket_unittest.cc
Insertions: 3, Deletions: 3.
@@ -188,9 +188,9 @@
// We expect Write to be called once.
EXPECT_CALL(*mock_stream_socket_, Write(_, _, _, _))
- .WillOnce([&](net::IOBuffer* buf, int buf_len,
- net::CompletionOnceCallback callback,
- const net::NetworkTrafficAnnotationTag&) {
+ .WillOnce([](net::IOBuffer* buf, int buf_len,
+ net::CompletionOnceCallback callback,
+ const net::NetworkTrafficAnnotationTag&) {
return buf_len; // Return number of bytes written
});
```
Change information
Commit message:
Expand test coverage for StreamPacketSocket
This CL expands the StreamPacketSocketTest suite to provide comprehensive
coverage for the StreamPacketSocket class. The new tests verify:
- Connection state checking (SendFailsWhenNotConnected).
- Sending failures (SendToFailsWithAddressMismatch, SendLargePacketFails).
- Sending successes via Write on the underlying socket (SendSuccess).
- Proper closure behavior and cleanup (Close).
- Setting socket options on both connected and unconnected sockets
(SetOptionInitialized, SetOptionUninitialized).
To facilitate testing without the network stack, this CL also introduces
FakeStreamPacketProcessor and MockStreamSocket.
Bug: None
Change-Id: Id9f796a7d6b9ebeac6e72a8dc41aec4e59a11e52
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618559}
Files:
- M remoting/protocol/stream_packet_socket_unittest.cc
Change size: M
Delta: 1 file changed, 188 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages