[crd host] Add fractional_coordinate to MouseEvent mojo struct [chromium/src : main]

1 view
Skip to first unread message

Yuwei Huang (Gerrit)

unread,
Feb 20, 2026, 5:48:03 PM (yesterday) Feb 20
to Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Joe Downing

Yuwei Huang voted and added 1 comment

Votes added by Yuwei Huang

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yuwei Huang . resolved

PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Downing
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
Gerrit-Change-Number: 7596767
Gerrit-PatchSet: 1
Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
Gerrit-Attention: Joe Downing <joe...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 22:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Downing (Gerrit)

unread,
Feb 20, 2026, 5:59:00 PM (yesterday) Feb 20
to Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
Attention needed from Yuwei Huang

Joe Downing voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yuwei Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
    Gerrit-Change-Number: 7596767
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 22:58:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yuwei Huang (Gerrit)

    unread,
    Feb 20, 2026, 6:07:56 PM (yesterday) Feb 20
    to Chromium IPC Reviews, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Chromium IPC Reviews

    Yuwei Huang added 1 comment

    Patchset-level comments
    Yuwei Huang . resolved

    Thanks! Adding IPC reviewer.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chromium IPC Reviews
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
    Gerrit-Change-Number: 7596767
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 23:07:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    Feb 20, 2026, 6:08:33 PM (yesterday) Feb 20
    to Yuwei Huang, Chromium IPC Reviews, Mustafa Emre Acer, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Mustafa Emre Acer

    Message from gwsq

    From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
    IPC: mea...@chromium.org

    📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

    IPC reviewer(s): mea...@chromium.org


    Reviewer source(s):
    mea...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mustafa Emre Acer
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
    Gerrit-Change-Number: 7596767
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 23:08:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mustafa Emre Acer (Gerrit)

    unread,
    Feb 20, 2026, 7:23:43 PM (yesterday) Feb 20
    to Yuwei Huang, Chromium IPC Reviews, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Yuwei Huang

    Mustafa Emre Acer voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yuwei Huang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
    Gerrit-Change-Number: 7596767
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Comment-Date: Sat, 21 Feb 2026 00:23:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yuwei Huang (Gerrit)

    unread,
    Feb 20, 2026, 7:25:14 PM (yesterday) Feb 20
    to Mustafa Emre Acer, Chromium IPC Reviews, Joe Downing, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org

    Yuwei Huang voted and added 1 comment

    Votes added by Yuwei Huang

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Yuwei Huang . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
    Gerrit-Change-Number: 7596767
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Sat, 21 Feb 2026 00:25:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 20, 2026, 7:27:58 PM (yesterday) Feb 20
    to Yuwei Huang, Mustafa Emre Acer, Chromium IPC Reviews, Joe Downing, chromium...@chromium.org, chromotin...@chromium.org, ipc-securi...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [crd host] Add fractional_coordinate to MouseEvent mojo struct

    The Wayland injector uses fractional coordinates instead of absolute
    coordinates, so this CL adds the missing mojo (de)serialization for it.
    Bug: 475611769
    Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
    Reviewed-by: Joe Downing <joe...@chromium.org>
    Reviewed-by: Mustafa Emre Acer <mea...@chromium.org>
    Commit-Queue: Yuwei Huang <yuw...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1588170}
    Files:
    • M remoting/host/mojom/desktop_session.mojom
    • M remoting/host/mojom/remoting_mojom_traits.cc
    • M remoting/host/mojom/remoting_mojom_traits.h
    Change size: S
    Delta: 3 files changed, 23 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joe Downing, +1 by Mustafa Emre Acer
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibabfe36bccf17bc67f34ab73cb1fda2a10b0e118
    Gerrit-Change-Number: 7596767
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yuwei Huang <yuw...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joe Downing <joe...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Reviewer: Yuwei Huang <yuw...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages