Are we using closure compiler on the new settings page?

[Dan Beam]

Hey everybody,

I don't see any compiled_resources.gyp files in chrome/browser/resources/{md_,}settings/, which is generally how we use ninja + closure compiler.

Are you guys interesting in compiling the new settings page?  Are there technical hurdles to doing this?  (e.g. polymer-y @tags?)

I'm mentioning it now because (from personal experience) it's harder to add compilation after something is done and you wont get the benefits of compile-time checking while developing your product (more /headdesk moments).

Just something to think about.  I know most of you have worked with closure compiler on previous projects (though the integration and tooling might've been a little silkier).

-- Dan

[Kyle Horimoto]

Jeremy is working on a compiler pass for Polymer elements. After that's done (and we've migrated to Polymer 0.8), we'll be compiling the new settings page.

--
You received this message because you are subscribed to the Google Groups "Chromium Settings" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-setti...@chromium.org.
To post to this group, send email to chromium...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-settings/CANpe7K0PxcO3bMN6ZENBZ-_0ZK2%3DXqmGXzbiwcLg8a334YTkBQ%40mail.gmail.com.

[Dan Beam]

On Wed, Apr 22, 2015 at 4:18 PM, Kyle Horimoto <khor...@chromium.org> wrote:

Jeremy is working on a compiler pass for Polymer elements.

Yeah, this is what I remembered vaguely as being an issue.

 

After that's done (and we've migrated to Polymer 0.8), we'll be compiling the new settings page.

Awesome!

-- Dan

 

On Wed, Apr 22, 2015 at 1:15 PM, Dan Beam <db...@chromium.org> wrote:

Hey everybody,

I don't see any compiled_resources.gyp files in chrome/browser/resources/{md_,}settings/, which is generally how we use ninja + closure compiler.

Are you guys interesting in compiling the new settings page?  Are there technical hurdles to doing this?  (e.g. polymer-y @tags?)

I'm mentioning it now because (from personal experience) it's harder to add compilation after something is done and you wont get the benefits of compile-time checking while developing your product (more /headdesk moments).

Just something to think about.  I know most of you have worked with closure compiler on previous projects (though the integration and tooling might've been a little silkier).

-- Dan

--
You received this message because you are subscribed to the Google Groups "Chromium Settings" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-setti...@chromium.org.
To post to this group, send email to chromium...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-settings/CANpe7K0PxcO3bMN6ZENBZ-_0ZK2%3DXqmGXzbiwcLg8a334YTkBQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Chromium Settings" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-setti...@chromium.org.
To post to this group, send email to chromium...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-settings/CA%2Bmjah%3DafodyJEJNsL88dcj5cyV%2BuskfNKMYRQkT_o8mdqERBQ%40mail.gmail.com.

[Jeremy Klein]

One more time from the right email address:

What Kyle said. Basically the compiler pass is good to go as far as Chrome is concerned. There are some subtle issues with renaming, but we don't run the renamed code in Chrome anyway so it's ok there. The only thing we're blocked on for compilation at this point is switching over to 0.8.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-settings/CANpe7K1n2Q5HC-285tWmfdBjVyot1M4X7-N8hXJHbGC76oE3XQ%40mail.gmail.com.