temporarily stop restarting usbmuxd in iOS18 devices [chromium/src : main]

0 views
Skip to first unread message

Justin Cohen (Gerrit)

unread,
4:50 PM (7 hours ago) 4:50 PM
to Yue She, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org
Attention needed from Yue She

Justin Cohen added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Justin Cohen . resolved

I wonder if iOS17 devices are broken stuff. This just checks Xcode version, right?

Open in Gerrit

Related details

Attention is currently required from:
  • Yue She
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib4a638b639bea6d3ca22b4f5cc88db86fd4a33f3
Gerrit-Change-Number: 5665770
Gerrit-PatchSet: 2
Gerrit-Owner: Yue She <yue...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Yue She <yue...@google.com>
Gerrit-Attention: Yue She <yue...@google.com>
Gerrit-Comment-Date: Tue, 02 Jul 2024 20:50:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yue She (Gerrit)

unread,
5:19 PM (6 hours ago) 5:19 PM
to Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org
Attention needed from Justin Cohen

Yue She added 1 comment

Patchset-level comments
Justin Cohen . unresolved

I wonder if iOS17 devices are broken stuff. This just checks Xcode version, right?

Yue She

I think most ios17 devices are running on xcode15 (except for ios17-beta-device) as we did not roll xcode main to xcode16. If there's any issue, I'm okay with ios17-beta-device being down for a bit

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib4a638b639bea6d3ca22b4f5cc88db86fd4a33f3
    Gerrit-Change-Number: 5665770
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yue She <yue...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Yue She <yue...@google.com>
    Gerrit-Attention: Justin Cohen <justi...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Jul 2024 21:19:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Justin Cohen <justi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Justin Cohen (Gerrit)

    unread,
    9:07 PM (3 hours ago) 9:07 PM
    to Yue She, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org
    Attention needed from Yue She

    Justin Cohen voted and added 1 comment

    Votes added by Justin Cohen

    Code-Review+1

    1 comment

    Patchset-level comments
    Justin Cohen . resolved

    I wonder if iOS17 devices are broken stuff. This just checks Xcode version, right?

    Yue She

    I think most ios17 devices are running on xcode15 (except for ios17-beta-device) as we did not roll xcode main to xcode16. If there's any issue, I'm okay with ios17-beta-device being down for a bit

    Justin Cohen

    ok, sounds risky but if we can revert to restore that's OK.

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yue She
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib4a638b639bea6d3ca22b4f5cc88db86fd4a33f3
    Gerrit-Change-Number: 5665770
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yue She <yue...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Yue She <yue...@google.com>
    Gerrit-Attention: Yue She <yue...@google.com>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 01:05:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Yue She <yue...@google.com>
    Comment-In-Reply-To: Justin Cohen <justi...@chromium.org>
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages