Return BrowserWindowInterface from DownloadCommands::GetBrowser() [chromium/src : main]
0 views
Skip to first unread message
Antonio Gomes Netto (Gerrit)
Jul 8, 2026, 8:59:17 PM (13 hours ago) Jul 8
to Antonio Gomes Netto, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium-bedrock-reviews, chromium...@chromium.org, chlily...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org
Attention needed from chromium-bedrock-reviews
Antonio Gomes Netto added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- chromium-bedrock-reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jul 8, 2026, 9:03:43 PM (13 hours ago) Jul 8
to Antonio Gomes Netto, chromium-bedrock-reviews, Colin Blundell, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chlily...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org
Attention needed from Colin Blundell
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
blun...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
3:14 AM (7 hours ago) 3:14 AM
to Antonio Gomes Netto, Colin Blundell, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chlily...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org
Attention needed from Antonio Gomes Netto
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antonio Gomes Netto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Gomes Netto (Gerrit)
8:17 AM (2 hours ago) 8:17 AM
to Antonio Gomes Netto, Colin Blundell, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chlily...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org
Antonio Gomes Netto voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:28 AM (2 hours ago) 8:28 AM
to Antonio Gomes Netto, Colin Blundell, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chlily...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Return BrowserWindowInterface from DownloadCommands::GetBrowser()
DownloadCommands::GetBrowser() only builds a
ScopedTabbedBrowserDisplayer and returns its browser, and all five call
sites feed the result to APIs that already take a BrowserWindowInterface
(or content::PageNavigator, which BrowserWindowInterface implements):
OpenURL, ShowSafeBrowsingEnhancedProtectionWithIph, and
DownloadProtectionService::ShowDetailsForDownload. So change
GetBrowser() to return BrowserWindowInterface*; the call sites are
unchanged.
This removes the last concrete-Browser use in download_commands.cc, so
its chrome/browser/ui/browser.h include is dropped. Two download-bubble
headers were relying on that include's transitive `class Browser;`
forward declaration; give them their own forward declaration.
R=chromium-bed...@google.com
Bug: 353332589
Change-Id: Ibbc1946232ec6fff42b440526da1650efe6091e5
Commit-Queue: Antonio Gomes Netto <toni...@igalia.com>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659484}
Files:
- M chrome/browser/download/download_commands.cc
- M chrome/browser/download/download_commands.h
- M chrome/browser/ui/views/download/bubble/download_bubble_row_list_view.h
- M chrome/browser/ui/views/download/bubble/download_bubble_row_view.h
Change size: S
Delta: 4 files changed, 8 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages