Delete unused overflow view [chromium/src : main]

0 views
Skip to first unread message

Alison Gale (Gerrit)

unread,
Jan 13, 2026, 2:18:38 PMJan 13
to TopChrome team GWSQ, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from TopChrome team GWSQ

Alison Gale voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • TopChrome team GWSQ
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I526caebee47e45b892f695e7fb02a12d46e065d6
Gerrit-Change-Number: 7465212
Gerrit-PatchSet: 2
Gerrit-Owner: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: TopChrome team GWSQ <top-chr...@google.com>
Gerrit-Attention: TopChrome team GWSQ <top-chr...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:18:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jan 13, 2026, 2:25:01 PMJan 13
to Alison Gale, TopChrome team GWSQ, Mickey Burks, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Mickey Burks

Message from gwsq

Reviewer source(s):
micke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/team/topchrome/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Mickey Burks
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I526caebee47e45b892f695e7fb02a12d46e065d6
Gerrit-Change-Number: 7465212
Gerrit-PatchSet: 2
Gerrit-Owner: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Mickey Burks <micke...@chromium.org>
Gerrit-CC: TopChrome team GWSQ <top-chr...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Mickey Burks <micke...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:24:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mickey Burks (Gerrit)

unread,
Jan 13, 2026, 2:33:52 PMJan 13
to Alison Gale, TopChrome team GWSQ, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Alison Gale

Mickey Burks voted and added 1 comment

Votes added by Mickey Burks

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mickey Burks . resolved

I'm curious how this came to be, but no argument here

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I526caebee47e45b892f695e7fb02a12d46e065d6
    Gerrit-Change-Number: 7465212
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Mickey Burks <micke...@chromium.org>
    Gerrit-CC: TopChrome team GWSQ <top-chr...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Alison Gale <ag...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:33:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alison Gale (Gerrit)

    unread,
    Jan 13, 2026, 2:45:01 PMJan 13
    to Mickey Burks, TopChrome team GWSQ, Chromium LUCI CQ, chromium...@chromium.org

    Alison Gale voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I526caebee47e45b892f695e7fb02a12d46e065d6
    Gerrit-Change-Number: 7465212
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Mickey Burks <micke...@chromium.org>
    Gerrit-CC: TopChrome team GWSQ <top-chr...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:44:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 2:47:53 PMJan 13
    to Alison Gale, Mickey Burks, TopChrome team GWSQ, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Delete unused overflow view
    Change-Id: I526caebee47e45b892f695e7fb02a12d46e065d6
    Reviewed-by: Mickey Burks <micke...@chromium.org>
    Commit-Queue: Alison Gale <ag...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568598}
    Files:
    • M chrome/browser/ui/BUILD.gn
    • D chrome/browser/ui/views/tabs/overflow_view.cc
    • D chrome/browser/ui/views/tabs/overflow_view.h
    • D chrome/browser/ui/views/tabs/overflow_view_unittest.cc
    • M chrome/test/BUILD.gn
    Change size: L
    Delta: 5 files changed, 0 insertions(+), 982 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mickey Burks
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I526caebee47e45b892f695e7fb02a12d46e065d6
    Gerrit-Change-Number: 7465212
    Gerrit-PatchSet: 3
    Gerrit-Owner: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mickey Burks <micke...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages