Steve Kobes (Gerrit)

unread,

Feb 10, 2026, 9:16:21 AMFeb 10

to Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Morten Stenshorne, Kentaro Hara, Chromium Metrics Reviews

Steve Kobes has uploaded the change for review

Steve Kobes would like Stephen Nusko, Chromium LUCI CQ and Mikihito Matsuura to review this change.

Commit message

Revert "[PA] Add TaskControlledPurge to fieldtrial"

This reverts commit 7053c500f98ab15855aa0a3330fd0fd884402f79.

Reason for revert: causing crashes on CQ, crbug.com/483092892

Original change's description:
> [PA] Add TaskControlledPurge to fieldtrial
>
> PartitionAllocSchedulerLoopQuarantineTaskControlledPurge is a feature to
> replace
> PartitionAllocSchedulerLoopQuarantineTaskObserverForBrowserUIThread. It
> is more widely-available and its performance characteristic is to be
> determined through Finch experiments.
>
> Bug: 351974425
> Change-Id: Iba926a0ce636f531d66adca9ca6be8c1ee4ca915
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7519605
> Commit-Queue: Mikihito Matsuura <mi...@google.com>
> Reviewed-by: Stephen Nusko <nus...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1581619}

Bug: 351974425

Change-Id: I87083e90ae4ea0db7e747380d077af70e7373369

Change diff

diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
index f9f91f88..51cd0d0e 100644
--- a/testing/variations/fieldtrial_testing_config.json
+++ b/testing/variations/fieldtrial_testing_config.json
@@ -19512,11 +19512,10 @@
                     },
                     "enable_features": [
                         "PartitionAllocSchedulerLoopQuarantine",
-                        "PartitionAllocSchedulerLoopQuarantineTaskControlledPurge",
+                        "PartitionAllocSchedulerLoopQuarantineTaskObserverForBrowserUIThread",
                         "PartitionAllocWithAdvancedChecks"
                     ],
                     "disable_features": [
-                        "PartitionAllocSchedulerLoopQuarantineTaskObserverForBrowserUIThread",
                         "ScreenAIPartitionAllocAdvancedChecksEnabled"
                     ]
                 }

Change information

Files:

M testing/variations/fieldtrial_testing_config.json

Change size: XS

Delta: 1 file changed, 1 insertion(+), 2 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Steve Kobes (Gerrit)

unread,

Feb 10, 2026, 9:19:33 AMFeb 10

to Rubber Stamper, Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Morten Stenshorne, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Mikihito Matsuura and Stephen Nusko

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Mikihito Matsuura
Stephen Nusko

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

Feb 10, 2026, 9:20:21 AMFeb 10

to Steve Kobes, Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Morten Stenshorne, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Mikihito Matsuura and Stephen Nusko

Rubber Stamper voted Bot-Commit+1

Bot-Commit

+1

Open in Gerrit

Related details

Attention is currently required from:

Mikihito Matsuura
Stephen Nusko

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steve Kobes (Gerrit)

unread,

Feb 10, 2026, 9:25:31 AMFeb 10

to Benoit Lize, Will Harris, Rubber Stamper, Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Morten Stenshorne, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Benoit Lize, Mikihito Matsuura, Stephen Nusko and Will Harris

Steve Kobes added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Steve Kobes . resolved

Adding some base/allocator OWNERS in other time zones

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize
Mikihito Matsuura
Stephen Nusko
Will Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steve Kobes (Gerrit)

unread,

Feb 10, 2026, 9:27:38 AMFeb 10

to Benoit Lize, Will Harris, Stephen Nusko, Rubber Stamper, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Morten Stenshorne, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Benoit Lize, Mikihito Matsuura, Stephen Nusko and Will Harris

Steve Kobes voted and added 1 comment

Votes added by Steve Kobes

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Steve Kobes . resolved

Oh maybe Rubber-Stamper is sufficient

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize
Mikihito Matsuura
Stephen Nusko
Will Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

Feb 10, 2026, 9:32:14 AMFeb 10

to Steve Kobes, Benoit Lize, Will Harris, Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Morten Stenshorne, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Benoit Lize, Mikihito Matsuura, Stephen Nusko, Steve Kobes and Will Harris

Rubber Stamper voted Bot-Commit+1

Bot-Commit

+1

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize
Mikihito Matsuura
Stephen Nusko

Steve Kobes
Will Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steve Kobes (Gerrit)

unread,

Feb 10, 2026, 9:33:25 AMFeb 10

to Benoit Lize, Will Harris, Rubber Stamper, Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Morten Stenshorne, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Benoit Lize, Mikihito Matsuura, Stephen Nusko and Will Harris

Steve Kobes added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Steve Kobes . resolved

Seems not (Gerrit lies)

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize
Mikihito Matsuura
Stephen Nusko

Will Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Morten Stenshorne (Gerrit)

unread,

Feb 10, 2026, 9:38:27 AMFeb 10

to Steve Kobes, Benoit Lize, Will Harris, Rubber Stamper, Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Benoit Lize, Mikihito Matsuura, Stephen Nusko, Steve Kobes and Will Harris

Morten Stenshorne voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize
Mikihito Matsuura
Stephen Nusko

Steve Kobes
Will Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steve Kobes (Gerrit)

unread,

Feb 10, 2026, 9:39:06 AMFeb 10

to Morten Stenshorne, Benoit Lize, Will Harris, Rubber Stamper, Stephen Nusko, Chromium LUCI CQ, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Attention needed from Benoit Lize, Mikihito Matsuura, Stephen Nusko and Will Harris

Steve Kobes voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize
Mikihito Matsuura
Stephen Nusko

Will Harris

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 10, 2026, 10:08:45 AMFeb 10

to Steve Kobes, Morten Stenshorne, Benoit Lize, Will Harris, Rubber Stamper, Stephen Nusko, Mikihito Matsuura, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "[PA] Add TaskControlledPurge to fieldtrial"

This reverts commit 7053c500f98ab15855aa0a3330fd0fd884402f79.

Reason for revert: causing crashes on CQ, see crbug.com/483092892.



Original change's description:
> [PA] Add TaskControlledPurge to fieldtrial
>
> PartitionAllocSchedulerLoopQuarantineTaskControlledPurge is a feature to
> replace
> PartitionAllocSchedulerLoopQuarantineTaskObserverForBrowserUIThread. It
> is more widely-available and its performance characteristic is to be
> determined through Finch experiments.
>
> Bug: 351974425
> Change-Id: Iba926a0ce636f531d66adca9ca6be8c1ee4ca915
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7519605
> Commit-Queue: Mikihito Matsuura <mi...@google.com>
> Reviewed-by: Stephen Nusko <nus...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1581619}

Bug: 351974425, 483092892

Change-Id: I87083e90ae4ea0db7e747380d077af70e7373369

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7562909

Reviewed-by: Morten Stenshorne <mste...@chromium.org>

Commit-Queue: Steve Kobes <sko...@chromium.org>

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/heads/main@{#1582492}

Files:

M testing/variations/fieldtrial_testing_config.json

Change size: XS

Delta: 1 file changed, 1 insertion(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Morten Stenshorne, Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Mikihito Matsuura (Gerrit)

unread,

12:19 AM (4 hours ago) 12:19 AM

to Chromium LUCI CQ, Steve Kobes, Morten Stenshorne, Benoit Lize, Will Harris, Rubber Stamper, Stephen Nusko, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org

Mikihito Matsuura has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Revert "[PA] Add TaskControlledPurge to fieldtrial" [chromium/src : main]

Steve Kobes (Gerrit)

Steve Kobes has uploaded the change for review

Commit message

Change diff

Change information

Related details

Steve Kobes (Gerrit)

New activity on the change

Related details

Rubber Stamper (Gerrit)

Rubber Stamper voted Bot-Commit+1

Related details

Steve Kobes (Gerrit)

Steve Kobes added 1 comment

Related details

Steve Kobes (Gerrit)

Steve Kobes voted and added 1 comment

Votes added by Steve Kobes

1 comment

Related details

Rubber Stamper (Gerrit)

Rubber Stamper voted Bot-Commit+1

Related details

Steve Kobes (Gerrit)

Steve Kobes added 1 comment

Related details

Morten Stenshorne (Gerrit)

Morten Stenshorne voted Code-Review+1

Related details

Steve Kobes (Gerrit)

Steve Kobes voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Mikihito Matsuura (Gerrit)

Mikihito Matsuura has created a revert of this change

Related details