WebNN: Build services/webnn/host as a component to fix duplicate singleton [chromium/src : main]
0 views
Skip to first unread message
Xu, Mingming1 (Gerrit)
Jun 24, 2026, 1:24:42 AM (9 days ago) Jun 24
to Hu, Ningxin, Rafael Cintron, Reilly Grant, Zou, Shiyi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Jiewei Qian
Attention needed from Hu, Ningxin, Rafael Cintron and Reilly Grant
Xu, Mingming1 added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hu, Ningxin
- Rafael Cintron
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hu, Ningxin (Gerrit)
Jun 24, 2026, 1:44:49 PM (8 days ago) Jun 24
to Xu, Mingming1, Rafael Cintron, Reilly Grant, Zou, Shiyi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Jiewei Qian
Attention needed from Rafael Cintron, Reilly Grant and Xu, Mingming1
Hu, Ningxin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hu, Ningxin
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Rafael Cintron
- Reilly Grant
- Xu, Mingming1
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
Jun 24, 2026, 4:42:49 PM (8 days ago) Jun 24
to Xu, Mingming1, Reilly Grant, Hu, Ningxin, Rafael Cintron, Zou, Shiyi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Jiewei Qian
Attention needed from Rafael Cintron and Xu, Mingming1
Reilly Grant voted and added 2 comments![]( "Open in Gerrit")
Votes added by Reilly Grant
| Code-Review | +1 |
2 comments
Patchset-level comments
Reilly Grant . resolved
LGTM with a formatting nit
Commit Message
Reilly Grant . unresolved
Please click the "format" button underneath the commit message to rewrap the lines in this message to the correct column width.
Related details
Attention is currently required from:
- Rafael Cintron
- Xu, Mingming1
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xu, Mingming1 (Gerrit)
Jun 24, 2026, 9:39:51 PM (8 days ago) Jun 24
to Rafael Cintron, Reilly Grant, Hu, Ningxin, Zou, Shiyi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Jiewei Qian
Xu, Mingming1 added 1 comment![]( "Open in Gerrit")
Commit Message
Please click the "format" button underneath the commit message to rewrap the lines in this message to the correct column width.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xu, Mingming1 (Gerrit)
Jun 24, 2026, 9:40:02 PM (8 days ago) Jun 24
to Rafael Cintron, Reilly Grant, Hu, Ningxin, Zou, Shiyi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Jiewei Qian
Xu, Mingming1 voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 10:00:37 PM (8 days ago) Jun 24
to Xu, Mingming1, Rafael Cintron, Reilly Grant, Hu, Ningxin, Zou, Shiyi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Jiewei Qian
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
WebNN: Build services/webnn/host as a component to fix duplicate singleton
Fixes a browser-process crash on Windows during WebNN ORT context
creation:
[WebNN] [OpenVINOExecutionProvider] is already in ready state before
`EnsureReadyAsync()` is called.
`ExecutionProviderInitializer` is a process-wide singleton whose state
machine is designed to run `Initialize()` exactly once: the first
`EnsureExecutionProvidersReady()` call activates the EP catalog and
posts `Initialize()`, which calls `EnsureReadyAsync()` on each provider
and drives it to the Ready state.
But `services/webnn/host` was a `source_set`, which in a component build
is statically linked into every dependent component. It is depended on
by both `content.dll` and `components_viz_host.dll`, and the browser
process loads both, so each got its own copy of the singleton's `static`
storage -- two `ExecutionProviderInitializer` instances in one process
(observed as two distinct `this` pointers on the same thread).
Both instances ran `Initialize()`. The first drove the providers to the
Ready state; the second then found a provider already Ready before it
had called `EnsureReadyAsync()` and hit the `LOG(FATAL)`, crashing the
browser.
Build `//services/webnn/host` as a `component()` instead of a
`source_set()` and export its public symbols with
`COMPONENT_EXPORT(WEBNN_HOST)`. As a component it links into its own
shared library, so `content.dll` and `components_viz_host.dll` share a
single copy of the code and thus a single
`ExecutionProviderInitializer`. `Initialize()` now runs exactly once.
Bug: 527089999
Change-Id: Ie4dbbe37afce5da49fc85090049c3a5070a1afc8
Reviewed-by: Reilly Grant <rei...@chromium.org>
Commit-Queue: Xu, Mingming1 <mingmi...@intel.com>
Reviewed-by: Hu, Ningxin <ningx...@intel.com>
Cr-Commit-Position: refs/heads/main@{#1652122}
Files:
- M services/webnn/host/BUILD.gn
- M services/webnn/host/execution_provider_initializer.h
- M services/webnn/host/weights_file_creator_impl.h
- M services/webnn/host/weights_file_provider.h
Change size: S
Delta: 4 files changed, 14 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Reilly Grant, +1 by Hu, Ningxin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages