[omnibox][webui] SubframeTaskBrowserTest & SubframeTaskPDFBrowserTest [chromium/src : main]
0 views
Skip to first unread message
manuk hovanesian (Gerrit)
Feb 4, 2026, 6:23:02 PM (3 days ago) Feb 4
to Michael Wojcicka, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Michael Wojcicka
manuk hovanesian voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wojcicka (Gerrit)
Feb 6, 2026, 5:03:43 PM (yesterday) Feb 6
to manuk hovanesian, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from manuk hovanesian
Michael Wojcicka voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Wojcicka
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Wojcicka . resolved
This change seems reasonable, LGTM. Thanks for the patience!
Related details
Attention is currently required from:
- manuk hovanesian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
manuk hovanesian (Gerrit)
Feb 6, 2026, 6:38:20 PM (yesterday) Feb 6
to Michael Wojcicka, Chromium LUCI CQ, chromium...@chromium.org
manuk hovanesian voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 6, 2026, 8:01:07 PM (yesterday) Feb 6
to manuk hovanesian, Michael Wojcicka, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[omnibox][webui] SubframeTaskBrowserTest & SubframeTaskPDFBrowserTest
Enable `kWebUIOmniboxPopup` & `kWebUIOmniboxAimPopup` and update 6
failing tests to pass with the features enabled:
SubframeTaskBrowserTest.TaskManagerHungSubframe
SubframeTaskBrowserTest.TaskManagerShowsSubframeTasks
All/SubframeTaskPDFBrowserTest.TaskManagerShowsIncognitoPDFSubframeTask/0
All/SubframeTaskPDFBrowserTest.TaskManagerShowsIncognitoPDFSubframeTask/1
All/SubframeTaskPDFBrowserTest.TaskManagerShowsPDFSubframeTask/0
All/SubframeTaskPDFBrowserTest.TaskManagerShowsPDFSubframeTask/1
The tests now expect 2 additional omnibox tasks.
Also makes the test expectations more complete:
EXPECT_THAT(actual_tasks, ElementsAre("task_0", "task_1", "task_2"))
instead of previously:
EXPECT_TRUE(StartsWith(actual_tasks[2], "task")
Bug: 452061489
Change-Id: I4866a6249728e99b4a3cac34433360aca99753ba
Auto-Submit: manuk hovanesian <man...@chromium.org>
Reviewed-by: Michael Wojcicka <mw...@google.com>
Commit-Queue: manuk hovanesian <man...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581215}
Files:
- M chrome/browser/task_manager/mock_web_contents_task_manager.h
- M chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc
Change size: L
Delta: 2 files changed, 169 insertions(+), 87 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Wojcicka
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
1:55 PM (8 hours ago) 1:55 PM
to Chromium LUCI CQ, manuk hovanesian, Michael Wojcicka, chromium...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages