[Extensions][Al] Add extensions checkbox to signout dialog when relevant [chromium/src : main]
Sophie Crowley (Gerrit)
Sophie Crowley added 5 comments![]( "Open in Gerrit")
[Extensions][Al] Add checkbox to signout dialog to remove extensionsSophie CrowleyI'm not sure this is exactly what we want to do. In this CL, the logic on whether or not to display the signout confirmation dialog doesn't change, you're just changing what this dialog looks like (and adding some functionality).
What we want is to display this dialog regardless of where the user signs out from and if they have account extensions (regardless of other data types). I don't think this CL displays the dialog when we need it.
Have created follow-up CL to handle making sure the dialog box shows up when we need it to (https://crrev.com/c/8034087) and have updated the description for this CL to be more accurate. Thank you!
Bug: 502977184Sophie CrowleyIf you tested this manually, would you mind uploading a screenshot to the bug ?
Done + added link to description -- Thanks!
UiState.SNACK_BAR,
UiState.UNSAVED_DATA,
UiState.SHOW_CONFIRM_DIALOG,Sophie CrowleyFollowing up on our offline discussion : it might end up being easier/more readable to create an entirely new dialog, rather than updating the existing one. In that case you would need to create a new UiState enum value here.
Resolving as choosing to include the checkbox in existing dialogs rather than creating new ones, now that we got confirmation that we can re-use the same text etc.
: "")Sophie CrowleyWill this still display the checkbox but with no text? Maybe we shouldn't add a checkbox at all when there are no account extensions ?
It will not display if the text is empty, this seems to be the canonical way to control visibility for the checkbox based on [here](https://crsrc.org/c/components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/ModalDialogView.java;drc=9a35579940dcd7d263d7c84e550d47314ba8ca44;l=603) (and its [test](https://crsrc.org/c/components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/ModalDialogViewTest.java;drc=b7b7bac01b971e929bf0dcf092e185da6d35e12d;l=568)). Have now added a comment about this.
After you sign out, your bookmarks, passwords, and more in your Google Account will be removed from this device.Sophie CrowleyThis will be the main text of the dialog box but it isn't exactly the same as the string displayed on Desktop. Can you double-check with Martin which one we actually want ?
Double checked -- we are okay to go with the existing Android sign out confirmation strings for now.
Related details
- Samar Chehade
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samar Chehade (Gerrit)
Samar Chehade added 1 comment![]( "Open in Gerrit")
LGTM, thanks for answering all my questions!
Related details
- Sophie Crowley
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samar Chehade (Gerrit)
Samar Chehade voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Sophie Crowley
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Crowley (Gerrit)
Sophie Crowley voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[Extensions][Al] Add extensions checkbox to signout dialog when relevant
When a user signs out of their primary account, they should have the
option to remove extensions that specifically associated with that
account. This CL updates SignOutCoordinator to, when a signout
confirmation dialog is shown, include a checkbox offering the option to
uninstall extensions if the signed-in account has any. If the user
selects this checkbox, it updates SigninManager to ensure the extensions
are uninstalled during the next sign-out operation.
(There was a lot of code duplication in the tests added for this
behavior so separated this out into its own helper functions for all
tests)
Example screenshot: https://crbug.com/502977184#comment18
- M chrome/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/SigninManager.java
- M chrome/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/SigninManagerImpl.java
- M chrome/browser/ui/android/signin/java/src/org/chromium/chrome/browser/ui/signin/SignOutCoordinator.java
- M chrome/browser/ui/android/signin/java/src/org/chromium/chrome/browser/ui/signin/SignOutCoordinatorTest.java
- M chrome/browser/ui/android/strings/android_chrome_strings.grd
- A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_SIGN_OUT_REMOVE_EXTENSIONS_MESSAGE.png.sha1
Code-Review: +1 by Samar Chehade
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |