actions revamp: Pass ETVM on EMC construction [chromium/src : main]

[Masa Fujita (Gerrit)]

Masa Fujita has uploaded the change for review

Commit message

actions revamp: Pass ETVM on EMC construction

This CL makes it so that `ExtensionsMenuCoordinator` receives
`ExtensionsToolbarViewModel` (as `ExtensionsContainer`) so that we don't
have to pass it as arguments often.

Bug: 473701535

Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Change diff

Change information

Files:

• M chrome/browser/ui/views/extensions/extensions_menu_coordinator.cc
• M chrome/browser/ui/views/extensions/extensions_menu_coordinator.h
• M chrome/browser/ui/views/extensions/extensions_toolbar_button.cc
• M chrome/browser/ui/views/extensions/extensions_toolbar_container.cc
• M chrome/browser/ui/views/extensions/extensions_toolbar_container.h
• M chrome/browser/ui/webui_browser/webui_browser_extensions_container.cc

Change size: M

Delta: 6 files changed, 35 insertions(+), 35 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 1

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-CC: chromium...@chromium.org

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 1

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 09 Jan 2026 06:08:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 2

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 09 Jan 2026 07:05:39 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 3

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 09 Jan 2026 07:40:00 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Attention needed from Emilia Paz

Masa Fujita added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Masa Fujita . resolved

Cleanup!

Open in Gerrit

Related details

Attention is currently required from:

• Emilia Paz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 4

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 08:36:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Emilia Paz (Gerrit)]

Attention needed from Masa Fujita

Emilia Paz voted and added 2 comments

Votes added by Emilia Paz

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Emilia Paz . resolved

Nice! Thanks for the fast follow up, Masa

File chrome/browser/ui/views/extensions/extensions_menu_coordinator.h

Line 68, Patchset 4 (Latest): // The `ExtensionsContainer` to use.

Emilia Paz . unresolved

mental-note: Lets update this comment when we rename the class, right now is very vague.

Open in Gerrit

Related details

Attention is currently required from:

• Masa Fujita

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 4

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Comment-Date: Fri, 09 Jan 2026 16:45:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted and added 2 comments

Votes added by Masa Fujita

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Masa Fujita . resolved

Thanks for the quick reviews~

File chrome/browser/ui/views/extensions/extensions_menu_coordinator.h

Line 68, Patchset 4: // The `ExtensionsContainer` to use.

Emilia Paz . resolved

mental-note: Lets update this comment when we rename the class, right now is very vague.

Masa Fujita

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 6

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Tue, 13 Jan 2026 03:41:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Emilia Paz <emil...@chromium.org>

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 6

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Tue, 13 Jan 2026 03:41:28 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Attention needed from Hidehiko Abe

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Masa Fujita . resolved

@hide...@chromium.org PTAL webui_browser_extensions_container.cc

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 6

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Tue, 13 Jan 2026 03:43:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Hidehiko Abe (Gerrit)]

Attention needed from Masa Fujita

Hidehiko Abe added 2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Hidehiko Abe . unresolved

could you check bot error?

File chrome/browser/ui/views/extensions/extensions_menu_coordinator.h

Line 27, Patchset 6 (Latest): ExtensionsContainer* extensions_container);

Hidehiko Abe . unresolved

nit: Could you document the lifetime requirement of `extensions_container`?

Can this be nullptr? If not, could you use raw_ref at L69, and use CHECK_DEREF() in the ctor?

Open in Gerrit

Related details

Attention is currently required from:

• Masa Fujita

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 6

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 05:15:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Masa Fujita (Gerrit)]

Masa Fujita removed a vote from this change

Removed Mega-CQ+1 by Masa Fujita <mas...@google.com>

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteVote

[Masa Fujita (Gerrit)]

Attention needed from Hidehiko Abe

Masa Fujita voted and added 2 comments

Votes added by Masa Fujita

Commit-Queue

+1

2 comments

Patchset-level comments

File-level comment, Patchset 6:

Hidehiko Abe . resolved

could you check bot error?

Masa Fujita

It looks unrelated to this change - I'll try again.

File chrome/browser/ui/views/extensions/extensions_menu_coordinator.h

Line 27, Patchset 6: ExtensionsContainer* extensions_container);

Hidehiko Abe . resolved

nit: Could you document the lifetime requirement of `extensions_container`?

Can this be nullptr? If not, could you use raw_ref at L69, and use CHECK_DEREF() in the ctor?

Masa Fujita

Ah sorry I forgot about this again, thanks for pointing it out! Done

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 7

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Tue, 13 Jan 2026 14:42:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>

[Hidehiko Abe (Gerrit)]

Attention needed from Masa Fujita

Hidehiko Abe voted and added 2 comments

Votes added by Hidehiko Abe

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Hidehiko Abe . resolved

lgtm

File chrome/browser/ui/views/extensions/extensions_menu_coordinator.h

Line 27, Patchset 6: ExtensionsContainer* extensions_container);

Hidehiko Abe . unresolved

nit: Could you document the lifetime requirement of `extensions_container`?

Can this be nullptr? If not, could you use raw_ref at L69, and use CHECK_DEREF() in the ctor?

Masa Fujita

Ah sorry I forgot about this again, thanks for pointing it out! Done

Hidehiko Abe

Could you document the lifetime requirement of extensions_container?

ping?

Open in Gerrit

Related details

Attention is currently required from:

• Masa Fujita

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I75f386fa17049ad08ed07f22a66d8d3329701ed2

Gerrit-Change-Number: 7414902

Gerrit-PatchSet: 7

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Comment-Date: Wed, 14 Jan 2026 05:37:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Masa Fujita <mas...@google.com>

Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>