Revert "[AtMemory] Update strings" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 20, 2026, 4:45:26 PM (yesterday) Jul 20
to Chromium LUCI CQ, Karol Sygiet, Jan Keitel, Piotr Kotynia, chromium...@chromium.org
Attention needed from Jan Keitel, Karol Sygiet and Piotr Kotynia

luci-bi...@appspot.gserviceaccount.com has uploaded the change for review

luci-bi...@appspot.gserviceaccount.com would like Chromium LUCI CQ, Karol Sygiet, Jan Keitel and Piotr Kotynia to review this change.

Commit message

Revert "[AtMemory] Update strings"

This reverts commit 72227365983d00f2493eb6f3c16705494c4957e7.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5160191994626048

Sample build with failed test: https://ci.chromium.org/b/8675734667817148721
Affected test(s):
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.autofill:AtMemoryBottomSheetRenderTest#testRenderBottomSheet](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.autofill:AtMemoryBottomSheetRenderTest%23testRenderBottomSheet?q=VHash%3A116e2ad6a8264cec)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest#testAtMemoryBottomSheetMainScreen__NightModeDisabled](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest%23testAtMemoryBottomSheetMainScreen__NightModeDisabled?q=VHash%3A116e2ad6a8264cec)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest#testAtMemoryBottomSheetMainScreen__NightModeEnabled](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest%23testAtMemoryBottomSheetMainScreen__NightModeEnabled?q=VHash%3A116e2ad6a8264cec)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest#testAtMemoryBottomSheetMainScreen_multilineSuggestionTitle__NightModeEnabled](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest%23testAtMemoryBottomSheetMainScreen_multilineSuggestionTitle__NightModeEnabled?q=VHash%3A116e2ad6a8264cec)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest#testAtMemoryBottomSheetView_zeroState__NightModeDisabled](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.ui.autofill:AtMemoryBottomSheetViewRenderTest%23testAtMemoryBottomSheetView_zeroState__NightModeDisabled?q=VHash%3A116e2ad6a8264cec)
and 1 more ...

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5160191994626048&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8124754&type=BUG

Original change's description:
> [AtMemory] Update strings
>
> This CL updates the strings to match the newest design. Translatable
> strings got their screenshots updated.
>
> Source: go/atmemory-mvp-strings
> Promo bubble: screen/BvYup2FyZuYun8U
> AtMemory popup hint: screen/9wj7FGQxNKdZEt6
>
> Bug: 517786635
> Change-Id: Ida40bf983b6d49fccebdd8a8bf61e0fa0da34c3f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8124754
> Reviewed-by: Piotr Kotynia <piotrk...@google.com>
> Reviewed-by: Jan Keitel <jke...@google.com>
> Commit-Queue: Karol Sygiet <syg...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1664803}
>
Bug: 517786635
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I469ee62b9da9e8d09641394bd337865146d3b04c

Change diff


Change information

Files:
  • M chrome/app/generated_resources.grd
  • M chrome/browser/ui/android/autofill/internal/java/src/org/chromium/chrome/browser/ui/autofill/AtMemoryBottomSheetViewRenderTest.java
  • M chrome/browser/ui/android/autofill/internal/java/src/org/chromium/chrome/browser/ui/autofill/AtMemorySearchBarViewRenderTest.java
  • M components/autofill_strings.grdp
  • M components/autofill_strings_grdp/IDS_AT_MEMORY_PROMO_DESCRIPTION.png.sha1
  • M components/autofill_strings_grdp/IDS_AT_MEMORY_PROMO_TITLE.png.sha1
  • M components/autofill_strings_grdp/IDS_AUTOFILL_AT_MEMORY_POPUP_SEARCH_BAR_PLACEHOLDER.png.sha1
Change size: S
Delta: 7 files changed, 16 insertions(+), 18 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
  • Karol Sygiet
  • Piotr Kotynia
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I469ee62b9da9e8d09641394bd337865146d3b04c
Gerrit-Change-Number: 8127835
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
Gerrit-Attention: Karol Sygiet <syg...@google.com>
Gerrit-Attention: Jan Keitel <jke...@google.com>
Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 20, 2026, 4:45:50 PM (yesterday) Jul 20
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Karol Sygiet, Jan Keitel, Piotr Kotynia, chromium...@chromium.org, charl...@google.com, zm...@google.com, srahim...@chromium.org
Attention needed from Jan Keitel, Karol Sygiet and Piotr Kotynia

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
  • Karol Sygiet
  • Piotr Kotynia
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I469ee62b9da9e8d09641394bd337865146d3b04c
Gerrit-Change-Number: 8127835
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
Gerrit-Attention: Karol Sygiet <syg...@google.com>
Gerrit-Attention: Jan Keitel <jke...@google.com>
Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 20:45:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 20, 2026, 4:46:17 PM (yesterday) Jul 20
to luci-bi...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Karol Sygiet, Jan Keitel, Piotr Kotynia, chromium...@chromium.org, charl...@google.com, zm...@google.com, srahim...@chromium.org
Attention needed from Jan Keitel, Karol Sygiet and Piotr Kotynia

Related details

Attention is currently required from:
  • Jan Keitel
  • Karol Sygiet
  • Piotr Kotynia
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I469ee62b9da9e8d09641394bd337865146d3b04c
    Gerrit-Change-Number: 8127835
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
    Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Attention: Karol Sygiet <syg...@google.com>
    Gerrit-Attention: Jan Keitel <jke...@google.com>
    Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 20:46:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Piotr Kotynia (Gerrit)

    unread,
    1:40 AM (18 hours ago) 1:40 AM
    to luci-bi...@appspot.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Karol Sygiet, Jan Keitel, chromium...@chromium.org, charl...@google.com, zm...@google.com, srahim...@chromium.org
    Attention needed from Jan Keitel and Karol Sygiet

    Piotr Kotynia added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Piotr Kotynia . resolved

    These are render test only and we need to accept the new delta. No need to revert IMO.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jan Keitel
    • Karol Sygiet
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I469ee62b9da9e8d09641394bd337865146d3b04c
    Gerrit-Change-Number: 8127835
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
    Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Attention: Karol Sygiet <syg...@google.com>
    Gerrit-Attention: Jan Keitel <jke...@google.com>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 05:40:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jan Keitel (Gerrit)

    unread,
    1:42 AM (18 hours ago) 1:42 AM
    to luci-bi...@appspot.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Karol Sygiet, Piotr Kotynia, chromium...@chromium.org, charl...@google.com, zm...@google.com, srahim...@chromium.org
    Attention needed from Karol Sygiet and Piotr Kotynia

    Jan Keitel added 1 comment

    Patchset-level comments
    Piotr Kotynia . resolved

    These are render test only and we need to accept the new delta. No need to revert IMO.

    Jan Keitel

    SGTM - can you take care of that?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Karol Sygiet
    • Piotr Kotynia
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I469ee62b9da9e8d09641394bd337865146d3b04c
    Gerrit-Change-Number: 8127835
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
    Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Attention: Karol Sygiet <syg...@google.com>
    Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 05:42:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Piotr Kotynia <piotrk...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Karol Sygiet (Gerrit)

    unread,
    1:50 AM (18 hours ago) 1:50 AM
    to luci-bi...@appspot.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Jan Keitel, Piotr Kotynia, chromium...@chromium.org, charl...@google.com, zm...@google.com, srahim...@chromium.org
    Attention needed from Piotr Kotynia

    Karol Sygiet voted and added 1 comment

    Votes added by Karol Sygiet

    Code-Review-1

    1 comment

    Patchset-level comments
    Karol Sygiet . unresolved

    I've approved new baselines in all of the failing pixel tests

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Piotr Kotynia
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is blockingCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I469ee62b9da9e8d09641394bd337865146d3b04c
      Gerrit-Change-Number: 8127835
      Gerrit-PatchSet: 1
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jan Keitel <jke...@google.com>
      Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
      Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
      Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>
      Gerrit-Comment-Date: Tue, 21 Jul 2026 05:49:52 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      blocking_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages